From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thor Thayer Subject: Re: [PATCH net-next 2/8] net: eth: altera: set rx and tx ring size before init_dma call Date: Thu, 15 Nov 2018 17:08:44 -0600 Message-ID: References: <20181115005047.28464-1-dwesterg@gmail.com> <20181115005047.28464-3-dwesterg@gmail.com> Reply-To: thor.thayer@linux.intel.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Dalon Westergreen To: Dalon Westergreen , netdev@vger.kernel.org, dinguyen@kernel.org Return-path: Received: from mga17.intel.com ([192.55.52.151]:47346 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbeKPJQG (ORCPT ); Fri, 16 Nov 2018 04:16:06 -0500 In-Reply-To: <20181115005047.28464-3-dwesterg@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/14/18 6:50 PM, Dalon Westergreen wrote: > From: Dalon Westergreen > > It is more appropriate to set the rx and tx ring size before calling > the init function for the dma. > > Signed-off-by: Dalon Westergreen > --- > drivers/net/ethernet/altera/altera_tse_main.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c > index dcb330129e23..0c0e8f9bba9b 100644 > --- a/drivers/net/ethernet/altera/altera_tse_main.c > +++ b/drivers/net/ethernet/altera/altera_tse_main.c > @@ -1166,6 +1166,10 @@ static int tse_open(struct net_device *dev) > int i; > unsigned long int flags; > > + /* set tx and rx ring size */ > + priv->rx_ring_size = dma_rx_num; > + priv->tx_ring_size = dma_tx_num; > + > /* Reset and configure TSE MAC and probe associated PHY */ > ret = priv->dmaops->init_dma(priv); > if (ret != 0) { > @@ -1208,8 +1212,6 @@ static int tse_open(struct net_device *dev) > priv->dmaops->reset_dma(priv); > > /* Create and initialize the TX/RX descriptors chains. */ > - priv->rx_ring_size = dma_rx_num; > - priv->tx_ring_size = dma_tx_num; > ret = alloc_init_skbufs(priv); > if (ret) { > netdev_err(dev, "DMA descriptors initialization failed\n"); > Acked-by: Thor Thayer