From: David Ahern <dsahern@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: jiri@resnulli.us, netdev@vger.kernel.org, idosch@mellanox.com,
mlxsw@mellanox.com
Subject: Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge
Date: Thu, 22 Feb 2018 12:27:35 -0700 [thread overview]
Message-ID: <fc62feba-7a01-d338-4274-1ea63b88a86b@gmail.com> (raw)
In-Reply-To: <20180222.135839.2197107822845062302.davem@davemloft.net>
On 2/22/18 11:58 AM, David Miller wrote:
> From: David Ahern <dsahern@gmail.com>
> Date: Wed, 21 Feb 2018 11:16:35 -0700
>
>> On 2/20/18 12:45 AM, Jiri Pirko wrote:
>>> From: Ido Schimmel <idosch@mellanox.com>
>>>
>>> Up until now we only allowed VLAN devices to be put in a VLAN-unaware
>>> bridge, but some users need the ability to enslave physical ports as
>>> well.
>>>
>>> This is achieved by mapping the port and VID 1 to the bridge's vFID,
>>> instead of the port and the VID used by the VLAN device.
>>>
>>> The above is valid because as long as the port is not enslaved to a
>>> bridge, VID 1 is guaranteed to be configured as PVID and egress
>>> untagged.
>>>
>>> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
>>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>>> ---
>>> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 12 +++++-------
>>> 1 file changed, 5 insertions(+), 7 deletions(-)
>>>
>>
>> Maybe I am missing something in the setup, but I am not getting
>> host-to-host connectivity. I booted a switch with this patch, configured
>> a bridge:
>
> I'm waiting for this discussion to be fully resolved before applying this
> patch. Just FYI...
>
Ido:
IPv4 works at boot; IPv6 requires the mcast snooping disable. For this
vlan-unaware bridges can that be set automatically?
And then, what are the options for lldp?
next prev parent reply other threads:[~2018-02-22 19:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 7:45 [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge Jiri Pirko
2018-02-21 18:16 ` David Ahern
2018-02-21 19:25 ` Ido Schimmel
2018-02-21 19:41 ` David Ahern
2018-02-21 20:24 ` Ido Schimmel
2018-02-21 20:31 ` David Ahern
2018-02-22 18:58 ` David Miller
2018-02-22 19:27 ` David Ahern [this message]
2018-02-22 20:55 ` Ido Schimmel
2018-02-22 21:48 ` David Ahern
2018-02-26 6:54 ` Ido Schimmel
2018-02-26 16:12 ` David Miller
2018-02-26 16:08 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc62feba-7a01-d338-4274-1ea63b88a86b@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).