[PATCH 0/2] net: ethernet: Drop empty platform remove function

[PATCH 0/2] net: ethernet: Drop empty platform remove function

[Uwe Kleine-König]

Hello,

this series drops all empty remove callbacks from platform drivers. A
callback that only returns zero is equivalent to no callback at all, so
use this simpler approach.

Best regards
Uwe

Uwe Kleine-König (2):
  net: ethernet: broadcom: bcm63xx_enet: Drop empty platform remove
    function
  net: ethernet: freescale: enetc: Drop empty platform remove function

 drivers/net/ethernet/broadcom/bcm63xx_enet.c      | 6 ------
 drivers/net/ethernet/freescale/enetc/enetc_ierb.c | 6 ------
 2 files changed, 12 deletions(-)


base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
-- 
2.38.1

[PATCH 1/2] net: ethernet: broadcom: bcm63xx_enet: Drop empty platform remove function

[Uwe Kleine-König]

A remove callback just returning 0 is equivalent to no remove callback
at all. So drop the useless function.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/net/ethernet/broadcom/bcm63xx_enet.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index d91fdb0c2649..2cf96892e565 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -2784,17 +2784,11 @@ static int bcm_enet_shared_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int bcm_enet_shared_remove(struct platform_device *pdev)
-{
-	return 0;
-}
-
 /* this "shared" driver is needed because both macs share a single
  * address space
  */
 struct platform_driver bcm63xx_enet_shared_driver = {
 	.probe	= bcm_enet_shared_probe,
-	.remove	= bcm_enet_shared_remove,
 	.driver	= {
 		.name	= "bcm63xx_enet_shared",
 		.owner  = THIS_MODULE,
-- 
2.38.1

Re: [PATCH 1/2] net: ethernet: broadcom: bcm63xx_enet: Drop empty platform remove function

[Florian Fainelli]

On 12/27/2022 1:45 PM, Uwe Kleine-König wrote:
> A remove callback just returning 0 is equivalent to no remove callback
> at all. So drop the useless function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

[PATCH 2/2] net: ethernet: freescale: enetc: Drop empty platform remove function

[Uwe Kleine-König]

A remove callback just returning 0 is equivalent to no remove callback
at all. So drop the useless function.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/net/ethernet/freescale/enetc/enetc_ierb.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ierb.c b/drivers/net/ethernet/freescale/enetc/enetc_ierb.c
index 91f02c505028..b307bef4dc29 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_ierb.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_ierb.c
@@ -127,11 +127,6 @@ static int enetc_ierb_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int enetc_ierb_remove(struct platform_device *pdev)
-{
-	return 0;
-}
-
 static const struct of_device_id enetc_ierb_match[] = {
 	{ .compatible = "fsl,ls1028a-enetc-ierb", },
 	{},
@@ -144,7 +139,6 @@ static struct platform_driver enetc_ierb_driver = {
 		.of_match_table = enetc_ierb_match,
 	},
 	.probe = enetc_ierb_probe,
-	.remove = enetc_ierb_remove,
 };
 
 module_platform_driver(enetc_ierb_driver);
-- 
2.38.1

Re: [PATCH 0/2] net: ethernet: Drop empty platform remove function

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue, 27 Dec 2022 22:45:06 +0100 you wrote:
> Hello,
> 
> this series drops all empty remove callbacks from platform drivers. A
> callback that only returns zero is equivalent to no callback at all, so
> use this simpler approach.
> 
> Best regards
> Uwe
> 
> [...]

Here is the summary with links:
  - [1/2] net: ethernet: broadcom: bcm63xx_enet: Drop empty platform remove function
    https://git.kernel.org/netdev/net/c/6b57bffa5f67
  - [2/2] net: ethernet: freescale: enetc: Drop empty platform remove function
    https://git.kernel.org/netdev/net/c/af691c94d022

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html