From: Denis Efremov <denis.e.efremov@oracle.com>
To: Martin Faltesek <mfaltesek@google.com>,
kuba@kernel.org, krzysztof.kozlowski@linaro.org
Cc: christophe.ricard@gmail.com, gregkh@linuxfoundation.org,
groeck@google.com, jordy@pwning.systems, krzk@kernel.org,
martin.faltesek@gmail.com, netdev@vger.kernel.org,
linux-nfc@lists.01.org, sameo@linux.intel.com, wklin@google.com,
theflamefire89@gmail.com
Subject: Re: [PATCH net v3 0/3] Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3
Date: Wed, 20 Jul 2022 11:24:59 +0400 [thread overview]
Message-ID: <fc85ff14-70d6-0c3e-247d-eda2284a5f6b@oracle.com> (raw)
In-Reply-To: <20220607025729.1673212-1-mfaltesek@google.com>
Hi,
On 6/7/22 06:57, Martin Faltesek wrote:
>
> Martin Faltesek (3):
> nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
> nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
> nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION
>
> drivers/nfc/st21nfca/se.c | 53 ++++++++++++++++++++++-----------------
> 1 file changed, 30 insertions(+), 23 deletions(-)
It looks like driver st-nci contains the same problems and all 3 fixes are
also applicable to st_nci_hci_connectivity_event_received() function.
At least I can see the memory leak
https://elixir.bootlin.com/linux/v5.19-rc7/source/drivers/nfc/st-nci/se.c#L343
Can you please double check the st-nci driver and send the same fixes to it?
Reported-by: Denis Efremov <denis.e.efremov@oracle.com>
Thanks,
Denis
next prev parent reply other threads:[~2022-07-20 7:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 2:57 [PATCH net v3 0/3] Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3 Martin Faltesek
2022-06-07 2:57 ` [PATCH net v3 1/3] nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION Martin Faltesek
2022-06-07 15:06 ` Guenter Roeck
2022-06-07 17:13 ` Krzysztof Kozlowski
2022-06-07 2:57 ` [PATCH net v3 2/3] nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling Martin Faltesek
2022-06-07 15:07 ` Guenter Roeck
2022-06-07 17:15 ` Krzysztof Kozlowski
2022-06-07 2:57 ` [PATCH net v3 3/3] nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION Martin Faltesek
2022-06-07 15:09 ` Guenter Roeck
2022-06-08 7:09 ` Krzysztof Kozlowski
2022-06-08 18:00 ` [PATCH net v3 0/3] Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3 patchwork-bot+netdevbpf
2022-07-20 7:24 ` Denis Efremov [this message]
2022-07-20 14:53 ` Martin Faltesek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc85ff14-70d6-0c3e-247d-eda2284a5f6b@oracle.com \
--to=denis.e.efremov@oracle.com \
--cc=christophe.ricard@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@google.com \
--cc=jordy@pwning.systems \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=martin.faltesek@gmail.com \
--cc=mfaltesek@google.com \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=theflamefire89@gmail.com \
--cc=wklin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).