From: Jeff Layton <jlayton@kernel.org>
To: NeilBrown <neil@brown.name>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Chuck Lever <chuck.lever@oracle.com>,
Alexander Aring <alex.aring@gmail.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
Steve French <sfrench@samba.org>,
Paulo Alcantara <pc@manguebit.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
Bharath SM <bharathsm@microsoft.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
David Howells <dhowells@redhat.com>,
Tyler Hicks <code@tyhicks.com>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>,
Amir Goldstein <amir73il@gmail.com>,
Namjae Jeon <linkinjeon@kernel.org>,
Steve French <smfrench@gmail.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Carlos Maiolino <cem@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, netfs@lists.linux.dev,
ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-xfs@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v5 09/17] vfs: clean up argument list for vfs_create()
Date: Thu, 06 Nov 2025 07:08:59 -0500 [thread overview]
Message-ID: <fc9765e8c58fbbc14c8066f685477da0cb2b55d0.camel@kernel.org> (raw)
In-Reply-To: <176237805165.634289.1849067298194355086@noble.neil.brown.name>
On Thu, 2025-11-06 at 08:27 +1100, NeilBrown wrote:
> On Thu, 06 Nov 2025, Jeff Layton wrote:
> > As Neil points out:
> >
> > "I would be in favour of dropping the "dir" arg because it is always
> > d_inode(dentry->d_parent) which is stable."
> >
> > ...and...
> >
> > "Also *every* caller of vfs_create() passes ".excl = true". So maybe we
> > don't need that arg at all."
> >
> > Drop both arguments from vfs_create() and fix up the callers.
> >
> > Suggested-by: NeilBrown <neilb@ownmail.net>
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
>
> This I like.
>
> Reviewed-by: NeilBrown <neil@brown.name>
>
> It would be consistent to also remove the 'dir' arg from vfs_mkdir(),
> vfs_mknod(), etc. I wouldn't do that until we find out what other
> people think of the change.
>
I was thinking that too. I can roll patches to do those as well, but at
this point I think I'd rather do that on top of this series rather than
in the context of it.
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2025-11-06 12:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 16:53 [PATCH v5 00/17] vfs: recall-only directory delegations for knfsd Jeff Layton
2025-11-05 16:53 ` [PATCH v5 01/17] filelock: make lease_alloc() take a flags argument Jeff Layton
2025-11-11 10:49 ` Jan Kara
2025-11-05 16:53 ` [PATCH v5 02/17] filelock: rework the __break_lease API to use flags Jeff Layton
2025-11-11 10:57 ` Jan Kara
2025-11-05 16:53 ` [PATCH v5 03/17] filelock: add struct delegated_inode Jeff Layton
2025-11-11 11:01 ` Jan Kara
2025-11-05 16:53 ` [PATCH v5 04/17] filelock: push the S_ISREG check down to ->setlease handlers Jeff Layton
2025-11-05 16:53 ` [PATCH v5 05/17] vfs: add try_break_deleg calls for parents to vfs_{link,rename,unlink} Jeff Layton
2025-11-05 16:53 ` [PATCH v5 06/17] vfs: allow mkdir to wait for delegation break on parent Jeff Layton
2025-11-05 16:53 ` [PATCH v5 07/17] vfs: allow rmdir " Jeff Layton
2025-11-05 16:53 ` [PATCH v5 08/17] vfs: break parent dir delegations in open(..., O_CREAT) codepath Jeff Layton
2025-11-05 16:53 ` [PATCH v5 09/17] vfs: clean up argument list for vfs_create() Jeff Layton
2025-11-05 21:27 ` NeilBrown
2025-11-06 12:08 ` Jeff Layton [this message]
2025-11-11 10:37 ` Jan Kara
2025-11-05 16:53 ` [PATCH v5 10/17] vfs: make vfs_create break delegations on parent directory Jeff Layton
2025-11-05 16:53 ` [PATCH v5 11/17] vfs: make vfs_mknod " Jeff Layton
2025-11-05 16:53 ` [PATCH v5 12/17] vfs: make vfs_symlink break delegations on parent dir Jeff Layton
2025-11-05 16:53 ` [PATCH v5 13/17] filelock: lift the ban on directory leases in generic_setlease Jeff Layton
2025-11-05 16:54 ` [PATCH v5 14/17] nfsd: allow filecache to hold S_IFDIR files Jeff Layton
2025-11-05 16:54 ` [PATCH v5 15/17] nfsd: allow DELEGRETURN on directories Jeff Layton
2025-11-05 16:54 ` [PATCH v5 16/17] nfsd: wire up GET_DIR_DELEGATION handling Jeff Layton
2025-11-05 16:54 ` [PATCH v5 17/17] vfs: expose delegation support to userland Jeff Layton
2025-11-11 10:48 ` Jan Kara
2025-11-11 12:14 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc9765e8c58fbbc14c8066f685477da0cb2b55d0.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=alex.aring@gmail.com \
--cc=amir73il@gmail.com \
--cc=anna@kernel.org \
--cc=bharathsm@microsoft.com \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=code@tyhicks.com \
--cc=dakr@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=ecryptfs@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=jack@suse.cz \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neil@brown.name \
--cc=netdev@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=pc@manguebit.org \
--cc=rafael@kernel.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).