From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Jan-Simon_M=F6ller?= Subject: Re: [PATCH v2] mac80211: LLVMLinux: Remove VLAIS usage from mac80211 Date: Sun, 09 Mar 2014 00:41:41 +0100 Message-ID: References: <1394177091.4653.1.camel@jlt4.sipsolutions.net> <1394241960-1764-1-git-send-email-behanw@converseincode.com> <531B934C.31666.37555A14@pageexec.freemail.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: behanw-k/hB3zQhLwledRVtV/plodBPR1lH4CV8@public.gmane.org, John Linville , Johannes Berg , davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, linux-wireless , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Woodhouse , =?ISO-8859-1?Q?Vin=EDcius_Tinti?= , Mark Charlebois To: Sergei Antonov , pageexec-Y8qEzhMunLyT9ig0jae3mg@public.gmane.org Return-path: In-Reply-To: Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 9. M=C3=A4rz 2014 00:00:19 MEZ, Sergei Antonov wr= ote: >On 8 March 2014 23:01, PaX Team wrote: >> On 8 Mar 2014 at 21:29, Sergei Antonov wrote: >> >>> > - memset(&aead_req, 0, sizeof(aead_req)); >>> > + char aead_req_data[sizeof(struct aead_request) + >>> > + crypto_aead_reqsize(tfm) + >>> > + CRYPTO_MINALIGN] >CRYPTO_MINALIGN_ATTR; >> =20 >^^^^^^^^^^^^^^^^^^^^ >> wouldn't the underlined attribute ensure the required alignment? >Yes. Sorry, I overlooked it. > >I would remove unneeded CRYPTO_MINALIGN and get the alignment from the >target structure: > char aead_req_data[sizeof(struct aead_request) + > crypto_aead_reqsize(tfm)] > __attribute__((__aligned__(__alignof__(struct aead_request))))= ; LGTM --=20 Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gese= ndet. -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html