From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 625C423ED6A; Mon, 12 Jan 2026 16:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768234848; cv=none; b=tv99x5uaaDNISuG4ZDLG6oEJu/fdWfg4gs9FzW+gDXOKmksLYGA1hdLcPjaRjvzMCNXK8gip4IWgHFO4/jU/q8tJY9c4PZZa7GZebLPwR+LrZbj94SUnqXk5ljK+aAPv/Yc1HFNkgrwn+705tePSXplAqZxQC4e0hHG+cSRXkmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768234848; c=relaxed/simple; bh=/PdvU0M1gZ9pGznJXLnSLXthS7353A8aYAPJNcKB1vg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RvAl+HV6mmeakZD8wwguHhyVQRrvRVJs/XX6l7tq2GXnteTrHQ2ZV9XD5xu6aSwuGRbM59y0BMtiRGGZCVJeiZNUex7xMq/YZXjVnBBWJpjP+sFWRWEdEomUL2JoYQxy1yBhtYFU7P6QorQ5RSkUX1+J3/Kw9RRgpavDG8cfu/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ArJe9oo7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ArJe9oo7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E47BC116D0; Mon, 12 Jan 2026 16:20:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768234847; bh=/PdvU0M1gZ9pGznJXLnSLXthS7353A8aYAPJNcKB1vg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ArJe9oo7Hwl+ssrsthaaQAI7mi51T4urx1Tk/XaEeNYSOJINQVIYrGKQkUZKennKd cNG74KbAlT9/tyZRdxJFrIJd6EXmnNv/RDQ9XF2QLFwm2FeScUoyeF+qs/SpYgErjU JhiX4KZLQ8CRTPe6ptyrfJRCnK5zSZRUAxsIGNX/e7BeDt0o4KrJ6VDb70nsBmm9+t dPgDsolJmGF8jpdrTud9i3Mpdw8tpMlFLuOh/LznVEtM52VMaAKB0Pb1Mm97N/VUq7 gcCAjHE9CTn7g75O90oXwGw9JUvuIKIwL/c+RthTtoLhQ1JyiR89xuoxgHjNFxWJfs 1KflpLJ7HrJvg== Message-ID: Date: Mon, 12 Jan 2026 17:20:40 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 03/12] dpll: Add helpers to find DPLL pin fwnode To: Ivan Vecera Cc: netdev@vger.kernel.org, Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prathosh Satish , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , Jonathan Lemon , Richard Cochran , Alexander Lobakin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, Michal Schmidt , Petr Oros , Grzegorz Nitka References: <20260108182318.20935-1-ivecera@redhat.com> <20260108182318.20935-4-ivecera@redhat.com> <20260109-cooperative-chinchilla-of-swiftness-aebbc8@quoll> <09ffc379-85e5-41ce-b781-66ba6bb9a6c7@redhat.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <09ffc379-85e5-41ce-b781-66ba6bb9a6c7@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/01/2026 15:19, Ivan Vecera wrote: > > > On 1/9/26 10:55 AM, Krzysztof Kozlowski wrote: >> On Thu, Jan 08, 2026 at 07:23:09PM +0100, Ivan Vecera wrote: >>> Add helper functions to the DPLL core to retrieve a DPLL pin's firmware >>> node handle based on the "dpll-pins" and "dpll-pin-names" properties. >>> >>> * `fwnode_dpll_pin_node_get()`: matches the given name against the >>> "dpll-pin-names" property to find the correct index, then retrieves >>> the reference from "dpll-pins". >>> * `device_dpll_pin_node_get()`: a wrapper around the fwnode helper for >>> convenience when using a `struct device`. >>> >>> These helpers simplify the process for consumer drivers (such as Ethernet >>> controllers or PHYs) to look up their associated DPLL pins defined in >>> the DT or ACPI, which can then be passed to the DPLL subsystem to acquire >>> the pin object. >>> >>> Signed-off-by: Ivan Vecera >>> --- >>> drivers/dpll/dpll_core.c | 20 ++++++++++++++++++++ >>> include/linux/dpll.h | 15 +++++++++++++++ >>> 2 files changed, 35 insertions(+) >>> >> >> I don't see cells defined in your binding. Neither updated property.c. > > And if the cells are not required? I mean that dpll-names only specifies > array of phandles without parameters... > > e.g. > dpll-pin-names = "abc", "def"; > dpll-pins = <&dpll_pin_abc>, <&dpll_pin_def>; > > Should '#dpll-pin-cells' be defined as constantly equal to 0? I don't understand how can you guarantee for every possible future device to have always cells=0. If that's the case then indeed you do not need cells, but this needs explanation. You are designing now entire ABI, so you must design it fully, not just "works for me now". Lack of complete DTS - nothing here, nothing in the changelog - is IMO reason to NAK this patchset completely, also for reason me guessing the entire design instead of seeing the big picture. Best regards, Krzysztof