From mboxrd@z Thu Jan 1 00:00:00 1970 From: Davide Caratti Subject: Re: [PATCH net 1/5] net sched actions: fix coding style in pedit action Date: Wed, 20 Jun 2018 14:29:43 +0200 Message-ID: References: <1529427368-17129-1-git-send-email-mrv@mojatatu.com> <1529427368-17129-2-git-send-email-mrv@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us To: Roman Mashak , davem@davemloft.net Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53914 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750793AbeFTM3q (ORCPT ); Wed, 20 Jun 2018 08:29:46 -0400 In-Reply-To: <1529427368-17129-2-git-send-email-mrv@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2018-06-19 at 12:56 -0400, Roman Mashak wrote: > Fix coding style issues in tc pedit action detected by the > checkpatch script. > > Signed-off-by: Roman Mashak ... > --- > @@ -316,16 +318,15 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a, > hoffset + tkey->at); > goto bad; > } > - d = skb_header_pointer(skb, hoffset + tkey->at, 1, > - &_d); > + d = skb_header_pointer(skb, hoffset + tkey->at, > + 1, &_d); > if (!d) > goto bad; > offset += (*d & tkey->offmask) >> tkey->shift; > } hello Roman, nit: while we are here, what about changing the declaration of _d and *d to u8, so that the bitwise operation is done on unsigned? BTW: the patch (and the series) looks ok, but I guess it will better target net-next when the branch reopens thanks! -- davide