From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C2BCA9EA0 for ; Fri, 25 Oct 2019 21:52:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5EBFD21D7F for ; Fri, 25 Oct 2019 21:52:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mojatatu-com.20150623.gappssmtp.com header.i=@mojatatu-com.20150623.gappssmtp.com header.b="gfxNYywi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726270AbfJYVww (ORCPT ); Fri, 25 Oct 2019 17:52:52 -0400 Received: from mail-il1-f195.google.com ([209.85.166.195]:42656 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbfJYVww (ORCPT ); Fri, 25 Oct 2019 17:52:52 -0400 Received: by mail-il1-f195.google.com with SMTP id o16so3091835ilq.9 for ; Fri, 25 Oct 2019 14:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=U/XWgTNc45a7TLQZXtrXyswOpLPgr5RcFtG6hODuS8E=; b=gfxNYywipcWP7EuMxw2bJwVSbSfONWb/fDvOSG/um+JMb1KylliAil3I74JAnBhJd3 YcX15Tz083jX4tdAA8du5dtVof7n6Dg9KxPVMNFLDTCccCtZkYHEKaddF/NhPkY3wNv+ INvwZLCGnSpbp53B1x+dKWvjh2VnYg0O5C6u16qIuZlaTfCq0GP6VaZyN9FihLXp6nr/ G0rT0FirIK7YTQwWGX5f8syMkutnFL/iBP4RZ48QjJYVa8FXlQGGY1EL+NrbohYH21vI cvRjha5HlhrxEGj7vUiBPhKBZS2B+vQC2nF25c2JT5zHER8oKXFYYSLqbuxIawIs5WAY YQ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U/XWgTNc45a7TLQZXtrXyswOpLPgr5RcFtG6hODuS8E=; b=ohMe0YPu6OyeSzI+5do2QWev6rbzul6w4tv8lCWJREWWloRM19CTNgGqV//ePFrOr9 AByjaWv7ZmLf21gJIgcpk/yd5+z1JSADzxladAtmgo4MZ6Wx1R3vu7fDeJ5gL8RyOZdz DO1ulopq/9uWPc9iHY1g3TFClQICSzbKTOdbC0859/Iuf6BqEpLk9OzJTyllZaj6sBbp eGx4CwYfs6NscLbusx4rrsSQ4pl1FX3Ry3CwD/RMMHtMxo/cX7z5zEudkdaN2e2wxC5w vsjVGn8xpG3sA7jE4T7l50yT+o/4ArcHduRlmQEq+G+pwnLcc1z+VpVZJeGW78yyOuh0 CbDg== X-Gm-Message-State: APjAAAXrCpRhFChDHB9rGI/lBRaddoj7PRIlMeQnMTpFaD3041dPssKu S3XmGRsijW3y0Wm+Vv4ZIyO9IA== X-Google-Smtp-Source: APXvYqxCwi/ReIsPZGGXbZwMUBZeL45jhvs7ZUToBFgZfin/2LfyoF+n0g9dwev+ybd++QxQ2GWv6g== X-Received: by 2002:a92:d211:: with SMTP id y17mr7033417ily.28.1572040371527; Fri, 25 Oct 2019 14:52:51 -0700 (PDT) Received: from [10.0.0.194] ([64.26.149.125]) by smtp.googlemail.com with ESMTPSA id t74sm499001ili.17.2019.10.25.14.52.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Oct 2019 14:52:48 -0700 (PDT) Subject: Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag From: Jamal Hadi Salim To: Vlad Buslov Cc: Jiri Pirko , "netdev@vger.kernel.org" , "xiyou.wangcong@gmail.com" , "davem@davemloft.net" , "mleitner@redhat.com" , "dcaratti@redhat.com" , Eric Dumazet References: <20191022141804.27639-1-vladbu@mellanox.com> <78ec25e4-dea9-4f70-4196-b93fbc87208d@mojatatu.com> <20191024073557.GB2233@nanopsycho.orion> <90c329f6-f2c6-240f-f9c1-70153edd639f@mojatatu.com> <48a75bf9-d496-b265-bdb7-025dd2e5f9f9@mojatatu.com> <7488b589-4e34-d94e-e8e1-aa8ab773891e@mojatatu.com> <43d4c598-88eb-27b3-a4bd-c777143acf89@mojatatu.com> <07a6ceec-3a87-44cb-f92d-6a6d9d9bef81@mojatatu.com> <894e7d98-83b0-2eaf-000e-0df379e2d1f4@mojatatu.com> <710bf705-6a58-c158-4fdc-9158dfa34ed3@mojatatu.com> Message-ID: Date: Fri, 25 Oct 2019 17:52:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <710bf705-6a58-c158-4fdc-9158dfa34ed3@mojatatu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019-10-25 5:10 p.m., Jamal Hadi Salim wrote: > On 2019-10-25 5:05 p.m., Jamal Hadi Salim wrote: >> +    if (!root_flags && tb[TCA_ACT_ROOT_FLAGS]) { >> +        rf = nla_get_bitfield32(tb[TCA_ACT_ROOT_FLAGS]); >> +        root_flags = &rf; >> +    } > > > > !root_flags check doesnt look right. > Hopefully it makes more sense now.... > For completion: It compiled ;-> cheers, jamal