From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69A533845D8 for ; Sat, 3 Oct 2026 01:58:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790992692; cv=none; b=YWFb2MzlkYlRj5N8JHJDkJ/KExU7wBlyy933Oc00VfBaZcZ69zI097/9eFChQ74SdjPTDE5wVzyYFxB8+kFGgAttLTad+xt4ozwjiVzZMVIJgytyR0fdJhVQDln2qKOuIhnrXJWEu2xokpwOWJGE4cyhIRCcwx5VqzwSIGA2Axk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790992692; c=relaxed/simple; bh=cmroKXnJCIz4HrrG2XpvDyEJXeY3XwMjRROTNLLJrVk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pLODh21V9JodFfaNPjHFS2vJgB1XAsK22590xJ5okUxpSu2aD8oLQn2xYFmu4MwvtIw2/GIxbmCanF04YiJFeSaGeEX8AUt/9FiF+ZqBUgfwcyNhtXkYuIs8UYxUpFqS4kC39kiAdbT+ewxRjC4P6O6+6o5dGg3+vu8iswPMvbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=GLC766N0; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="GLC766N0" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6930P8Nj1780776; Sat, 3 Oct 2026 01:57:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=NI9X7DQsFH/qwQ3lN loQEK/JRrsyUB9o9pUjyW+bS70=; b=GLC766N0l5El7GKHXJeYnDFYRRFZIs9zj Hr/etbT6EyStY2eNfcqY5sXazmlFz1O7Lyv1usuxTqLJT7fl6PTEstCrjLDQv5D2 U6LHHOJEy5Xosg87U5Zrw++aXO8UgfBKpNE7U7yrtuswN24TLa48u2gxerZaPjXQ PPgjOlcjd4lCF4dQSogqRG2tjfIugiWHTGeqkZTsFaOz1LFb0nYjEcY0P/EwQTyR gND82Gsem2w0Vrpw1zzaowUOh8lpeCSm9mt8yhfj9FvoxMtLYo9VCogWaHvjIOGN O+5wnTVLENMusHDFBfHbc4zCMEdR+C6C8Bc9K0HTdxkYypZHZfW9g== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4h2q4j87n7-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sat, 03 Oct 2026 01:57:55 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 692NlVVF3271160; Sat, 3 Oct 2026 01:57:55 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4h1xk15agp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 03 Oct 2026 01:57:54 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6931vrv232113302 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 3 Oct 2026 01:57:53 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 42FC658059; Sat, 3 Oct 2026 01:57:53 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F23C45804B; Sat, 3 Oct 2026 01:57:50 +0000 (GMT) Received: from localhost.localdomain (unknown [9.67.102.94]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Sat, 3 Oct 2026 01:57:50 +0000 (GMT) From: Mingming Cao To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, horms@kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, nnac123@linux.ibm.com, maddy@linux.ibm.com, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, davemarq@linux.ibm.com, bjking1@linux.ibm.com, Mingming Cao Subject: [PATCH net-next 7/7] ibmveth: wait for in-flight transmits in ibmveth_close() Date: Fri, 2 Oct 2026 18:57:19 -0700 Message-Id: X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: RLHkcwMRPwWZZ4tUyFEZpqQKyZxYohv- X-Proofpoint-GUID: Qja7TpskROvl5YPt4XWlqHgbttk_KLH3 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDAzMDAwNSBTYWx0ZWRfX96Gg+kReJ2uz jtUlLmYmxEX0rMiw57GDbvTVF5h8o/LkXg677gpzefEoM7/K3Zmh1xbK9Om4LlSI6jL+zwCoonG VflZoNBBheTAq33fKkj0xVeab12nzh0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDAzMDAwNSBTYWx0ZWRfX+RTvQb5mRhlV s8+vIJeed9byWMV/lfXF427/zQTF00uk3Di7CFYtQaDy39Falrb0py3ckiKyW5EUYWzyVpllom5 BkiRdNkLzBEd+kflYe8cn+vS1Jv3HotBkhucKCIAxzMbSFuC7O0XdejHpTFhVFzGPlzK3r1Z2YL UBHvTkud545MiPLRhsLoauALWgFb4VvCblhVohTgc721gy/E4w/+MrYNLNA2nHvJRdoPCxSNf+A WF1ZRO+vPnOtwv2q61L3FE4dESItelompm4+fI0lWPLFx0UCR0wUrlM6vYqDk7MR74PH5jCI0+b /B0bsCGi57kvlAyGCBNmj7D7H4wrUJgzkaJ6SXkCohiVJNtXEl3Crx9tNSgYt7uMAcjYxb5uAWG 4WnzFCm6UW0SJG+uH+G0pOFnY8GzQYmz9/9xZNf3RXZo6IEeQeG9A+BQwoCTdrN6Hk1roWbeo2a yqkZM7BMw1IsHlLD7JA== X-Authority-Analysis: v=2.4 cv=eYeo7LEH c=1 sm=1 tr=0 ts=6ac06124 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=660iZSQnnn4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=4X-BtLuwBG46RJIdyTYA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-02_07,2026-10-02_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 clxscore=1015 spamscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2610030005 ibmveth_close() frees the TX buffers after netif_tx_stop_all_queues(), which does not wait for an ibmveth_start_xmit() already running on another CPU. That transmit can copy into a freed buffer and hand PHYP a stale DMA address. ifdown and the reset work go through dev_close(), which drains TX first, but MTU, csum/TSO and buffer pool changes call ibmveth_close() directly while traffic flows. Use netif_tx_disable(), which waits for running transmits. The race was not reproduced. Tested on a POWER10 LPAR with MTU changes during a ping flood, with no warnings. Fixes: d6832ca48d8a ("ibmveth: Copy tx skbs into a premapped buffer") Signed-off-by: Mingming Cao --- drivers/net/ethernet/ibm/ibmveth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 132c740b5844..5acd5e49b0ad 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -827,7 +827,7 @@ static int ibmveth_close(struct net_device *netdev) napi_disable(&adapter->napi); - netif_tx_stop_all_queues(netdev); + netif_tx_disable(netdev); h_vio_signal(adapter->vdev->unit_address, VIO_IRQ_DISABLE); -- 2.39.3 (Apple Git-146)