From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] ip: promote missed packets to the -s row
Date: Tue, 22 Sep 2020 20:24:14 -0600 [thread overview]
Message-ID: <fcf01759-febb-9794-b323-e762eaef6896@gmail.com> (raw)
In-Reply-To: <20200916194249.505389-1-kuba@kernel.org>
On 9/16/20 1:42 PM, Jakub Kicinski wrote:
> missed_packet_errors are much more commonly reported:
>
> linux$ git grep -c '[.>]rx_missed_errors ' -- drivers/ | wc -l
> 64
> linux$ git grep -c '[.>]rx_over_errors ' -- drivers/ | wc -l
> 37
>
> Plus those drivers are generally more modern than those
> using rx_over_errors.
>
> Since recently merged kernel documentation makes this
> preference official, let's make ip -s output more informative
> and let rx_missed_errors take the place of rx_over_errors.
>
> Before:
>
> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
> link/ether 00:0a:f7:c1:4d:38 brd ff:ff:ff:ff:ff:ff
> RX: bytes packets errors dropped overrun mcast
> 6.04T 4.67G 0 0 0 67.7M
> RX errors: length crc frame fifo missed
> 0 0 0 0 7
> TX: bytes packets errors dropped carrier collsns
> 3.13T 2.76G 0 0 0 0
> TX errors: aborted fifo window heartbeat transns
> 0 0 0 0 6
>
> After:
>
> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
> link/ether 00:0a:f7:c1:4d:38 brd ff:ff:ff:ff:ff:ff
> RX: bytes packets errors dropped missed mcast
> 6.04T 4.67G 0 0 7 67.7M
> RX errors: length crc frame fifo overrun
> 0 0 0 0 0
> TX: bytes packets errors dropped carrier collsns
> 3.13T 2.76G 0 0 0 0
> TX errors: aborted fifo window heartbeat transns
> 0 0 0 0 6
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> ip/ipaddress.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
applied to iproute2-next
prev parent reply other threads:[~2020-09-23 2:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 19:42 [PATCH iproute2-next] ip: promote missed packets to the -s row Jakub Kicinski
2020-09-18 15:44 ` David Ahern
2020-09-18 15:48 ` Jakub Kicinski
2020-09-19 4:52 ` David Ahern
2020-09-19 16:06 ` Stephen Hemminger
2020-09-21 21:49 ` Jakub Kicinski
2020-09-23 2:24 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcf01759-febb-9794-b323-e762eaef6896@gmail.com \
--to=dsahern@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).