From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net] rtnetlink: invoke 'cb->done' destructor before
 'cb->args' reset
Date: Thu, 1 Nov 2018 15:51:53 -0600
Message-ID: <fcf2e07f-fe41-6ecd-12d8-162becd06890@gmail.com>
References: <1540968178-18894-1-git-send-email-alexey.kodanev@oracle.com>
 <104f12e4-866b-b986-cb9d-28c40d5c5e84@gmail.com>
 <50d88abb-bfba-6c70-af68-7bac60a0d4b1@gmail.com>
 <dbd48fde-3a7f-2800-4317-4eab2ecfd41d@oracle.com>
 <11ce99ef-b587-4402-30df-0ae9c8a37dd0@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>
To: Alexey Kodanev <alexey.kodanev@oracle.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f196.google.com ([209.85.214.196]:44522 "EHLO
        mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726273AbeKBG4o (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 2 Nov 2018 02:56:44 -0400
Received: by mail-pl1-f196.google.com with SMTP id s5-v6so7888929plq.11
        for <netdev@vger.kernel.org>; Thu, 01 Nov 2018 14:51:57 -0700 (PDT)
In-Reply-To: <11ce99ef-b587-4402-30df-0ae9c8a37dd0@oracle.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 11/1/18 7:42 AM, Alexey Kodanev wrote:
> On 11/01/2018 04:11 PM, Alexey Kodanev wrote:
>> On 10/31/2018 08:35 PM, David Ahern wrote:
>>> On 10/31/18 10:55 AM, David Ahern wrote:
>>>> I think the simplest fix for 4.20 is to break the loop if ret is non-0 -
>>>> restore the previous behavior. 
>>>
>>> that is the only recourse. It has to bail if ret is non-0. Do you want
>>> to send a patch with that fix?
>>>
>>
>> I see, and inet6_dump_fib() cleanups fib6_walker if ret is zero. Will send the fix.
> 
> Can it happen that inet6_dump_fib() returns skb->len (0) in the below cases?
> 
> * 	if (arg.filter.flags & RTM_F_CLONED)
> 		return skb->len;
> 
>         ...
> 
> 	w = (void *)cb->args[2];
> 	if (!w) {
> 		...
> 		w = kzalloc(...)
>                 ...
> 
> * 	if (arg.filter.table_id) {
>                 ...
> 		if (!tb) {
> 			if (arg.filter.dump_all_families)
> 				return skb->len;
> 
> 
> Would it be safer to add "res = skb->len; goto out;" instead of "return skb->len;"
> so that it can call fib6_dump_end() for "res <= 0"? Or use cb->data instead of
> cb->args?
> 

Since res is initialized to 0, both of those can just be 'goto out;'
The break in dump_all is still needed though.