From: Andrew Lunn <andrew@lunn.ch>
To: dimitri.fedrau@liebherr.com
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dimitri Fedrau <dima.fedrau@gmail.com>
Subject: Re: [PATCH net-next 0/2] net: phy: dp83822: Add support for changing the transmit amplitude voltage
Date: Mon, 13 Jan 2025 14:54:28 +0100 [thread overview]
Message-ID: <fcffef06-c8d1-4398-bc20-30d252cd2fd2@lunn.ch> (raw)
In-Reply-To: <20250113-dp83822-tx-swing-v1-0-7ed5a9d80010@liebherr.com>
On Mon, Jan 13, 2025 at 06:40:11AM +0100, Dimitri Fedrau via B4 Relay wrote:
> Add support for changing the transmit amplitude voltage in 100BASE-TX mode.
> Add support for configuration via DT.
The commit message is supposed to answer the question "Why?". Isn't
reducing the voltage going to make the device non conforming? Why
would i want to break it? I could understand setting it a bit higher
than required to handle losses on the PCB and connector, so the
voltages measured on the RJ45 pins are conforming.
Also, what makes the dp8382 special? I know other PHYs can actually do
this. So why are we adding some vendor specific property just for
100base-tx?
Andrew
next prev parent reply other threads:[~2025-01-13 13:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 5:40 [PATCH net-next 0/2] net: phy: dp83822: Add support for changing the transmit amplitude voltage Dimitri Fedrau via B4 Relay
2025-01-13 5:40 ` [PATCH net-next 1/2] dt-bindings: net: " Dimitri Fedrau via B4 Relay
2025-01-13 5:40 ` [PATCH net-next 2/2] net: phy: " Dimitri Fedrau via B4 Relay
2025-01-14 11:00 ` Simon Horman
2025-01-15 17:23 ` kernel test robot
2025-01-15 22:44 ` kernel test robot
2025-01-13 13:54 ` Andrew Lunn [this message]
2025-01-13 14:18 ` [PATCH net-next 0/2] " Dimitri Fedrau
2025-01-13 15:59 ` Andrew Lunn
2025-01-16 9:56 ` Dimitri Fedrau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcffef06-c8d1-4398-bc20-30d252cd2fd2@lunn.ch \
--to=andrew@lunn.ch \
--cc=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=dimitri.fedrau@liebherr.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).