Re: [Intel-wired-lan] [PATCH net-next 01/12] dt-bindings: dpll: add common dpll-pin-consumer schema

[Ivan Vecera <ivecera@redhat.com>]

On 1/9/26 11:22 AM, Ivan Vecera wrote:
> 
> 
> On 1/9/26 10:48 AM, Krzysztof Kozlowski wrote:
>> On Thu, Jan 08, 2026 at 07:23:07PM +0100, Ivan Vecera wrote:
>>> Introduce a common schema for DPLL pin consumers. Devices such as 
>>> Ethernet
>>> controllers and PHYs may require connections to DPLL pins for 
>>> Synchronous
>>> Ethernet (SyncE) or other frequency synchronization tasks.
>>>
>>> Defining these properties in a shared schema ensures consistency across
>>> different device types that consume DPLL resources.
>>>
>>> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>>> ---
>>>   .../bindings/dpll/dpll-pin-consumer.yaml      | 30 +++++++++++++++++++
>>>   MAINTAINERS                                   |  1 +
>>>   2 files changed, 31 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/dpll/dpll-pin- 
>>> consumer.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/dpll/dpll-pin- 
>>> consumer.yaml b/Documentation/devicetree/bindings/dpll/dpll-pin- 
>>> consumer.yaml
>>> new file mode 100644
>>> index 0000000000000..60c184c18318a
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/dpll/dpll-pin-consumer.yaml
>>> @@ -0,0 +1,30 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/dpll/dpll-pin-consumer.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: DPLL Pin Consumer
>>> +
>>> +maintainers:
>>> +  - Ivan Vecera <ivecera@redhat.com>
>>> +
>>
>> You miss select. Without it this binding is no-op.
> 
> Will fix.
> 
>>> +description: |
>>
>> Drop |
> 
> Will do.
> 
>>> +  Common properties for devices that require connection to DPLL 
>>> (Digital Phase
>>> +  Locked Loop) pins for frequency synchronization (e.g. SyncE).
>>> +
>>> +properties:
>>> +  dpll-pins:
>>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
>>> +    description:
>>> +      List of phandles to the DPLL pin nodes connected to this device.
>>> +
>>> +  dpll-pin-names:
>>> +    $ref: /schemas/types.yaml#/definitions/string-array
>>> +    description:
>>> +      Names for the DPLL pins defined in 'dpll-pins', in the same 
>>> order.
>>> +
>>> +dependencies:
>>> +  dpll-pin-names: [ dpll-pins ]
>>
>> Binding should go to dtschema. See also commit
>> 3282a891060aace02e3eed4789739768060cea32 in dtschema or other examples
>> how to add new provider/consumer properties.

Quick questions... if the dpll pin consumer properties schema should go
to dtschema...

1) Should I remove this patch from this series? So this schema won't be
    a part of kernel
2) dtschema does not contain dpll-device and dpll-pin schemas now, I
    expect they should be added as well... or? I'm asking because there
    is also e.g. hwlock-consumer.yaml in dtschema but no hwlock

Thanks,
Ivan

> Will do.
> 
> Thanks for advice...
> 
> Ivan
>