From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8630F7DA63 for ; Thu, 15 Aug 2024 11:18:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723720721; cv=none; b=Ch2ps1cl5FbGM7Lln43gl1AnRkaQT2Fq8YrBaIzUqCEYGqPyAEoBvRbYAorWh3TedtVcFWhz3LAroqM7OAG5dZmTGrs3/6sJje8cqMtjjVqO4bzwoNFoROydxmGuwcnq0ppUqHAaiQKEDSafPVxdXvorTmgqWU5Hw4+gcY5D5XA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723720721; c=relaxed/simple; bh=GfzHkA3NEtdmCsr/KpIs6KlwwNWqBKlqq8cB1Tg+n5c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kk277iybcUCMorVxBSZfPDmokaWicbNdP1r8sOlskv4KFxZXBEejGpzqMXE0Z8UGLfnVCF+ZgPNjY7+XQrkp8RjITG9VTsLD7tUVAj4+Rbcc0DWZG8VTholFZ6vvPHJrEuUOA7VptTNS7xPYExffIjiimJvQB4I4+Lejsm0iOAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ClcjQcit; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ClcjQcit" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723720718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=24V3VGfwIrKGka7iIRCvCp2rkdbP5TtQ2k/YsWqeb00=; b=ClcjQcit89HLaWkst+62OniPPNn3E7JMuKgrar2cghJdhNENVGy/K30Qrqk4BL5I0k9kWv Qa/hRi3iZQVef1UnOKS6qsSfxdrp3uY7octyTeuu/dcybROGiWxVeGbj6EjLj3Yg6PhUAN mggxtBYNLW6hJv06ePGc5/bBhUF/d+8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-wfXPy-yNPAS3Xm_js_JbMw-1; Thu, 15 Aug 2024 07:18:37 -0400 X-MC-Unique: wfXPy-yNPAS3Xm_js_JbMw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4280b24ec7bso1603565e9.3 for ; Thu, 15 Aug 2024 04:18:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723720716; x=1724325516; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=24V3VGfwIrKGka7iIRCvCp2rkdbP5TtQ2k/YsWqeb00=; b=LkltBAyMmDnCJP/OV8LGY0Px4NiWxQn9yKRyBxDz7VLGTXjoNT1/w9v8DwtLWQR/IC LX5iUEp5r1npPGoL2Qz5WUc6klFlmv6E4s3XRRuVnYMPODK24OzjD1teEaCNQzx4Ux/b HZcpcqhMDUTa55Ywcto255k2hzfvlUvnS4PuxLiD8jwIYR8SPCwvyvLye0FgfiiQhSbR c+VUpoxIWwV6+z7uU5pN4JydezE1rGdnViVw/ux3LS075tAGfaRvnyWWchEpLY5ns1fx MnMUhxkdATI89GSqJbYo2kDmWeOPheokKLKhPS6XV25eaZIP2GDNoAm1g0F/tZCkf1jW t5+Q== X-Gm-Message-State: AOJu0YyoAjCp6i5E6VaxWPDKr6pQSeLU0AmEC1/5ZyTT6r45hvxFV7vd soY7kzPi0ioFziKHgGN3FspmgsNBHJMRcRNkCadb/pdpKU4AEfDNk8WK8MM9T+iF1M0DmygZzS9 /rsjbRAfc/7JNcNq+pDDs9AFcyEnfzwagxuRPDUmv6ImkuTrAngENhQ== X-Received: by 2002:a05:600c:35c5:b0:426:5f08:542b with SMTP id 5b1f17b1804b1-429e63a22aamr9302495e9.0.1723720715954; Thu, 15 Aug 2024 04:18:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGnOYnq3ro7PPvOKCikfdHFb1kTWeqIJYge0M34FZQMbh0yh0VysW0l11ZYuiNklVTcOTdkw== X-Received: by 2002:a05:600c:35c5:b0:426:5f08:542b with SMTP id 5b1f17b1804b1-429e63a22aamr9302335e9.0.1723720715429; Thu, 15 Aug 2024 04:18:35 -0700 (PDT) Received: from ?IPV6:2a0d:3344:1711:4010:5731:dfd4:b2ed:d824? ([2a0d:3344:1711:4010:5731:dfd4:b2ed:d824]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ded19627sm45254015e9.5.2024.08.15.04.18.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Aug 2024 04:18:34 -0700 (PDT) Message-ID: Date: Thu, 15 Aug 2024 13:18:33 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: Don't allow to attach xdp if bond slave device's upper already has a program To: Feng zhou , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, jiri@resnulli.us, bigeasy@linutronix.de, lorenzo@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, yangzhenze@bytedance.com, wangdongdong.6@bytedance.com References: <20240814090811.35343-1-zhoufeng.zf@bytedance.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20240814090811.35343-1-zhoufeng.zf@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/14/24 11:08, Feng zhou wrote: > From: Feng Zhou > > Cannot attach when an upper device already has a program, This > restriction is only for bond's slave devices, and should not be > accidentally injured for devices like eth0 and vxlan0. > > Signed-off-by: Feng Zhou > --- > net/core/dev.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/net/core/dev.c b/net/core/dev.c > index 6ea1d20676fb..e1f87662376a 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -9501,10 +9501,12 @@ static int dev_xdp_attach(struct net_device *dev, struct netlink_ext_ack *extack > } > > /* don't allow if an upper device already has a program */ > - netdev_for_each_upper_dev_rcu(dev, upper, iter) { > - if (dev_xdp_prog_count(upper) > 0) { > - NL_SET_ERR_MSG(extack, "Cannot attach when an upper device already has a program"); > - return -EEXIST; > + if (netif_is_bond_slave(dev)) { I think we want to consider even team port devices. Thanks, Paolo