From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] tun: no longer rely on RTNL in tun_fill_info()
Date: Mon, 6 Jul 2026 11:45:11 +0200 [thread overview]
Message-ID: <fd4b54b8-4e17-4519-866c-e0508e7b4ba0@redhat.com> (raw)
In-Reply-To: <20260701125112.3652880-1-edumazet@google.com>
On 7/1/26 2:51 PM, Eric Dumazet wrote:
> Update tun_fill_info() to read device configuration fields (flags, owner,
> group, numqueues, numdisabled) locklessly using READ_ONCE().
>
> Annotate all writes to these fields in the control paths with WRITE_ONCE()
> to prevent data races, as these fields can be modified concurrently via
> ioctls (TUNSETPERSIST, TUNSETOWNER, TUNSETGROUP, TUNSETIFF) or queue
> attaching/detaching.
Sashiko-gemini notes that:
__tun_chr_ioctl() -> tun_vnet_ioctl
can still update tun->flags with no annotation for TUN_VNET_LE. I'm not
sure if a follow-up or a v2 is preferred.
/P
prev parent reply other threads:[~2026-07-06 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 12:51 [PATCH net-next] tun: no longer rely on RTNL in tun_fill_info() Eric Dumazet
2026-07-02 3:09 ` Kuniyuki Iwashima
2026-07-03 15:43 ` Willem de Bruijn
2026-07-06 9:45 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd4b54b8-4e17-4519-866c-e0508e7b4ba0@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox