Re: [PATCH net-next 4/7] selftests: ovpn: enable TCP_NODELAY on TCP sockets

[Antonio Quartulli <antonio@openvpn.net>]

Hi,

On 08/10/2026 15:59, Neal Cardwell wrote:
> On Wed, Oct 7, 2026 at 9:38 AM Antonio Quartulli <antonio@openvpn.net> wrote:
>>
>> From: Marco Baffo <marco@mandelbit.com>
>>
>> Userspace now enables TCP_NODELAY by default. Enable it for
>> ovpn-cli's TCP sockets too.
> 
> This claim is accurate in context, but terse. I would suggest a more
> precise wording, like: “Since OpenVPN 2.7.6, openvpn unconditionally
> sets TCP_NODELAY on its TCP sockets. Do the same in ovpn-cli so the
> TCP selftests match that configuration.”

ok! I'll make the wording more precise and explicit about the version 
introducing this change in userspace.

> 
> Sashiko’s suggestion to keep an option for running with Nagle on seems
> worthwhile. Peers on 2.7.0–2.7.5, and mixed-version setups, will keep
> producing Nagle-on sockets under ovpn for a while. It might be nice to
> have test coverage to ensure those setups do not get broken by kernel
> changes.
> 

True, extending the tests to cover both case shouldn't be a big deal.

Will respin with both points addressed.

Regards,

-- 
Antonio Quartulli
OpenVPN Inc.