Netdev List
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: m.chetan.kumar@intel.com
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
	johannes@sipsolutions.net, ryazanov.s.a@gmail.com,
	loic.poulain@linaro.org, krishna.c.sudi@intel.com,
	m.chetan.kumar@linux.intel.com, linuxwwan@intel.com,
	Devegowda Chandrashekar <chandrashekar.devegowda@intel.com>
Subject: Re: [PATCH net-next 5/5] net: wwan: t7xx: Devlink documentation
Date: Thu, 18 Aug 2022 17:43:20 +0300 (EEST)	[thread overview]
Message-ID: <fd6e3c45-e074-122b-53c7-d622a337fbd@linux.intel.com> (raw)
In-Reply-To: <20220816042417.2416988-1-m.chetan.kumar@intel.com>

On Tue, 16 Aug 2022, m.chetan.kumar@intel.com wrote:

> From: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
> 
> Document the t7xx devlink commands usage for fw flashing &
> coredump collection.
> 
> Refer to t7xx.rst file for details.
> 
> Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
> Signed-off-by: Devegowda Chandrashekar <chandrashekar.devegowda@intel.com>
> ---

> +``t7xx`` driver uses fastboot protocol for fw flashing. In the fw flashing
> +procedure, fastboot command's & response's are exchanged between driver

Using 's here seems incorrect.

> +and wwan device.

> +Note: component "value" represents the partition type to be programmed.

"value" is hard to understand here. I'd just say "component selects the 
partition type to be programmed."

> +      - The detailed modem components log are captured in this region

"components log are" seems inconsistent.


-- 
 i.

      reply	other threads:[~2022-08-18 14:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16  4:24 [PATCH net-next 5/5] net: wwan: t7xx: Devlink documentation m.chetan.kumar
2022-08-18 14:43 ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd6e3c45-e074-122b-53c7-d622a337fbd@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=chandrashekar.devegowda@intel.com \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=krishna.c.sudi@intel.com \
    --cc=kuba@kernel.org \
    --cc=linuxwwan@intel.com \
    --cc=loic.poulain@linaro.org \
    --cc=m.chetan.kumar@intel.com \
    --cc=m.chetan.kumar@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=ryazanov.s.a@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox