Re: [PATCH iwl-net v3] ice/ptp: fix crosstimestamp reporting

["Nadezhdin, Anton" <anton.nadezhdin@intel.com>]

On 5/16/2025 8:58 PM, Simon Horman wrote:
> On Thu, May 15, 2025 at 02:32:36PM +0200, Anton Nadezhdin wrote:
>> Set use_nsecs=true as timestamp is reported in ns. Lack of this result
>> in smaller timestamp error window which cause error during phc2sys
>> execution on E825 NICs:
>> phc2sys[1768.256]: ioctl PTP_SYS_OFFSET_PRECISE: Invalid argument
>>
>> Before commit "Provide infrastructure for converting to/from a base clock"
> 
> Hi Anton,
> 
> Thanks for your patch.
> 
> I have some feedback on the form of the commit message, I hope it is useful.

Hi Simon,

Thank you for the feedback. I will go with such description in the next
version:
ice/ptp: fix crosstimestamp reporting

Set use_nsecs=true as timestamp is reported in ns. Lack of this result
in smaller timestamp error window which cause error during phc2sys
execution on E825 NICs:
phc2sys[1768.256]: ioctl PTP_SYS_OFFSET_PRECISE: Invalid argument

This problem was introduced in the cited commit which omitted setting
use_nsecs to true when converting the ice driver to use
convert_base_to_cs().

Testing hints (ethX is PF netdev):
phc2sys -s ethX -c CLOCK_REALTIME  -O 37 -m
phc2sys[1769.256]: CLOCK_REALTIME phc offset -5 s0 freq      -0 delay   0

> 
> ...