From: David Ahern <dsahern@gmail.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Roman Mashak <mrv@mojatatu.com>
Cc: David Miller <davem@davemloft.net>,
Stephen Hemminger <stephen@networkplumber.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 1/1] bridge: return error code when deleting Vlan
Date: Fri, 13 Oct 2017 08:31:42 -0600 [thread overview]
Message-ID: <fd85d139-f727-6ef7-ceec-8b6dba961bca@gmail.com> (raw)
In-Reply-To: <ba70b4c0-2bd9-9722-7101-e823d901f09f@cumulusnetworks.com>
On 10/12/17 8:15 PM, Nikolay Aleksandrov wrote:
> I do agree it's a bug, but there might be scripts that rely on it and
> don't check the return value when clearing vlans. They will end up with
> a partial clear and wrongly assumed state, so maybe leave the
> opportunistic delete but count if anything was actually deleted and send
> an event only then ?
+1
next prev parent reply other threads:[~2017-10-13 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 13:51 [PATCH net-next v2 1/1] bridge: return error code when deleting Vlan Roman Mashak
2017-10-12 14:19 ` David Ahern
2017-10-12 18:07 ` Roman Mashak
2017-10-12 18:12 ` Nikolay Aleksandrov
2017-10-13 2:03 ` Jamal Hadi Salim
2017-10-13 2:15 ` Nikolay Aleksandrov
2017-10-13 14:31 ` David Ahern [this message]
2017-10-13 16:00 ` Roman Mashak
2017-10-14 10:52 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd85d139-f727-6ef7-ceec-8b6dba961bca@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).