From: Nimrod Oren <noren@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net-next] selftests: drv-net: bump the timeout to 15min
Date: Thu, 13 Aug 2026 11:04:15 +0300 [thread overview]
Message-ID: <fdb9ff70-07d9-4966-a893-11dd7c338e66@nvidia.com> (raw)
In-Reply-To: <20260812171302.1888667-1-kuba@kernel.org>
On 12/08/2026 20:13, Jakub Kicinski wrote:
> The GRO test takes extra time on NICs which support HW-GRO and LRO
> (as it also runs the test cases against the NIC implementation).
> gro.py takes 6min on bnxt and 10min on mlx5 with debug kernel builds.
10m works for xdp.py but it seems that it isn't enough for gro.py :(
# ok 265 gro.test.lro_ipip_ip_ecn
not ok 1 selftests: drivers/net: gro.py # exit=130
# Totals: pass:0 fail:1 xfail:0 xpass:0 skip:0 error:0
NIPA RUNNER TIMEOUT 600 sec (graceful stop)
https://netdev.bots.linux.dev/logs/hwksft/CX7-dbg/results/776322/test-outputs/0-gro-py/stdout
> The delta between drivers is to some extent due to their defaults
> (mlx5 sillily defaults to queue-per-thread, while bnxt follows
> netif_get_num_default_rss_queues()).
>
> At the end of the day the defaults don't matter much - on larger
> machines all drivers will create more queues. We should bump
> the timeout. Let's give ourselves a 50% margin over mlx5's needs
> and set the timeout to 15min.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: noren@nvidia.com
> CC: shuah@kernel.org
> CC: linux-kselftest@vger.kernel.org
> ---
> tools/testing/selftests/drivers/net/settings | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/drivers/net/settings b/tools/testing/selftests/drivers/net/settings
> index eef533824a3c..e2206265f67c 100644
> --- a/tools/testing/selftests/drivers/net/settings
> +++ b/tools/testing/selftests/drivers/net/settings
> @@ -1 +1 @@
> -timeout=360
> +timeout=900
prev parent reply other threads:[~2026-08-13 8:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 17:13 [PATCH net-next] selftests: drv-net: bump the timeout to 15min Jakub Kicinski
2026-08-13 8:04 ` Nimrod Oren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdb9ff70-07d9-4966-a893-11dd7c338e66@nvidia.com \
--to=noren@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox