From: shaozhengchao <shaozhengchao@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<jhs@mojatatu.com>, <xiyou.wangcong@gmail.com>,
<jiri@resnulli.us>, <vladbu@mellanox.com>,
<weiyongjun1@huawei.com>, <yuehaibing@huawei.com>
Subject: Re: [PATCH net-next] net: sched: tbf: don't call qdisc_put() while holding tree lock
Date: Fri, 26 Aug 2022 09:25:45 +0800 [thread overview]
Message-ID: <fdca3c8d-42f6-1f2a-5b03-eaf3c394297d@huawei.com> (raw)
In-Reply-To: <20220825181305.773c9e64@kernel.org>
On 2022/8/26 9:13, Jakub Kicinski wrote:
> On Fri, 26 Aug 2022 09:12:48 +0800 Zhengchao Shao wrote:
>> The issue is the same to commit c2999f7fb05b ("net: sched: multiq: don't
>> call qdisc_put() while holding tree lock"). Qdiscs call qdisc_put() while
>> holding sch tree spinlock, which results sleeping-while-atomic BUG.
>>
>> Fixes: c266f64dbfa2 ("net: sched: protect block state with mutex")
>> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
>
> If it's a bug fix for a commit already in Linus's main tree it should
> come with [PATCH net] in the subject (i.e. without the -next).
> Please repost.
Hi Jakub:
Thank you for your reply. I will repost this patch.
Zhangchao Shao
prev parent reply other threads:[~2022-08-26 1:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 1:12 [PATCH net-next] net: sched: tbf: don't call qdisc_put() while holding tree lock Zhengchao Shao
2022-08-26 1:13 ` Jakub Kicinski
2022-08-26 1:25 ` shaozhengchao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdca3c8d-42f6-1f2a-5b03-eaf3c394297d@huawei.com \
--to=shaozhengchao@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladbu@mellanox.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox