Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Nicolò Giuliani - nicolo.giuliani6@studio.unibo.it"
	<nicolo.giuliani6@studio.unibo.it>
Cc: Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Richard Cochran <richardcochran@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: R: [PATCH net] net: dsa: mv88e6xxx: continue without PTP if the TAI period is invalid
Date: Sun, 20 Sep 2026 20:58:35 +0200	[thread overview]
Message-ID: <fde8b48a-10ed-46fd-b477-18ac57df8a88@lunn.ch> (raw)
In-Reply-To: <DU4PR01MB12163870875DEF21E5C39DD2D80852@DU4PR01MB12163.eurprd01.prod.exchangelabs.com>

On Sun, Sep 20, 2026 at 05:34:01PM +0000, Nicolò Giuliani - nicolo.giuliani6@studio.unibo.it wrote:
> 
> Hi Andrew,
> 
> > The point of the failure is to indicate an assumption in the driver is
> > not valid, and we need to examine the assumption.
> 
> You are right, and my patch only works around it.
> 
> > What does the datasheet for the 88E6193X say about this register? Has
> > its meaning changed? Marvell like moving registers around, is it
> > somewhere else?
> 
> I do not have the datasheet for this chip, so I cannot answer that from documentation.

I don't have the 88E6193X either. But i do have some other datasheets.

If the device is using the internal 250MHz clock, the register is
expected to contain 0x0FA0, 4000picoseconds. If i remember correctly,
the patch which changed things was because different devices have
different internal clocks, hence the need to read it.

There is however the option to use an external clock. This is
controlled via TAI register 0x1e. If bit 14 is 0, the internal clock
is used. If 1, the external clock is used. With the external clock,
you need to write to register 0x01 what the external clock period is,
in picoseconds.

So you probably want to check what register 0x1e contains.

	Andrew

  reply	other threads:[~2026-09-20 18:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19 19:52 [PATCH net] net: dsa: mv88e6xxx: continue without PTP if the TAI period is invalid Nicolo Giuliani via B4 Relay
2026-09-20 14:48 ` Andrew Lunn
2026-09-20 17:34   ` R: " Nicolò Giuliani - nicolo.giuliani6@studio.unibo.it
2026-09-20 18:58     ` Andrew Lunn [this message]
2026-09-20 19:08       ` R: " Nicolò Giuliani - nicolo.giuliani6@studio.unibo.it
2026-09-20 21:21         ` Andrew Lunn
2026-09-21  3:58           ` R: " Nicolò Giuliani - nicolo.giuliani6@studio.unibo.it

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fde8b48a-10ed-46fd-b477-18ac57df8a88@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolo.giuliani6@studio.unibo.it \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox