From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2-next v2 8/8] ip/tunnel: Unify local/remote endpoint address printing Date: Wed, 24 Jan 2018 11:40:02 -0700 Message-ID: References: <1516735170-20921-1-git-send-email-serhe.popovych@gmail.com> <1516735170-20921-9-git-send-email-serhe.popovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Serhey Popovych , netdev@vger.kernel.org Return-path: Received: from mail-pf0-f181.google.com ([209.85.192.181]:34316 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965045AbeAXSkF (ORCPT ); Wed, 24 Jan 2018 13:40:05 -0500 Received: by mail-pf0-f181.google.com with SMTP id e76so3785528pfk.1 for ; Wed, 24 Jan 2018 10:40:04 -0800 (PST) In-Reply-To: <1516735170-20921-9-git-send-email-serhe.popovych@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/23/18 12:19 PM, Serhey Popovych wrote: > Introduce and use tnl_print_endpoint() helper to print > of tunnel endpoint address. > > Note that for AF_INET and AF_INET6 inet_ntop(3) is used > that may return NULL in case of failure and while unlikely > format_host_rta() might return NULL too. Handle this case > when passing local/remote to print_string(). > > Signed-off-by: Serhey Popovych > --- > ip/link_gre.c | 21 ++------------------- > ip/link_gre6.c | 26 ++------------------------ > ip/link_ip6tnl.c | 15 ++------------- > ip/link_iptnl.c | 21 ++------------------- > ip/link_vti.c | 21 ++------------------- > ip/link_vti6.c | 21 ++------------------- > ip/tunnel.c | 27 +++++++++++++++++++++++++++ > ip/tunnel.h | 2 ++ > 8 files changed, 41 insertions(+), 113 deletions(-) > > This one no longer applies cleanly after the latest merge to master. Please update -- and fix the commit messages to use more than 50 columns.