Netdev List
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Dawei Feng <dawei.feng@seu.edu.cn>, Zilin Guan <zilin@seu.edu.cn>,
	netdev@vger.kernel.org, Sunil Goutham <sgoutham@marvell.com>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Eric Dumazet <edumazet@google.com>,
	Geethasowjanya Akula <gakula@marvell.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Jianhao Xu <jianhao.xu@seu.edu.cn>,
	Paolo Abeni <pabeni@redhat.com>,
	Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [PATCH net] octeontx2-pf: avoid double free of pool->stack on AQ init failure
Date: Mon, 18 May 2026 11:23:30 +0200	[thread overview]
Message-ID: <fe233758-26b8-4abc-ada9-d1f7c4102b08@web.de> (raw)
In-Reply-To: <20260515151826.1005397-1-dawei.feng@seu.edu.cn>

…
> Set pool->stack to NULL immediately after the local free so the shared
…
                                                 so that?

How do you think about to avoid a bit of duplicate source code
in affected function implementations?
https://elixir.bootlin.com/linux/v7.1-rc3/source/drivers/net/ethernet/marvell/octeontx2/nic/cn20k.c#L615-L629
https://elixir.bootlin.com/linux/v7.1-rc3/source/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c#L1478-L1492


> The bug was first flagged by an experimental analysis tool we are
> developing for kernel memory-management bugs while analyzing
> v6.13-rc1. The tool is still under development and is not yet publicly
> available. Manual inspection confirms that the bug is still present in
> v7.1-rc3.

Under which circumstances will the mentioned software revision gap
be adjusted accordingly?

Regards,
Markus

  reply	other threads:[~2026-05-18  9:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 15:18 [PATCH net] octeontx2-pf: avoid double free of pool->stack on AQ init failure Dawei Feng
2026-05-18  9:23 ` Markus Elfring [this message]
2026-05-18  9:35   ` Greg KH
2026-05-19 20:26 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe233758-26b8-4abc-ada9-d1f7c4102b08@web.de \
    --to=markus.elfring@web.de \
    --cc=andrew+netdev@lunn.ch \
    --cc=dawei.feng@seu.edu.cn \
    --cc=edumazet@google.com \
    --cc=gakula@marvell.com \
    --cc=jianhao.xu@seu.edu.cn \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    --cc=stable@vger.kernel.org \
    --cc=zilin@seu.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox