From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D23C6C636CD for ; Tue, 7 Feb 2023 10:41:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231655AbjBGKli (ORCPT ); Tue, 7 Feb 2023 05:41:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231229AbjBGKle (ORCPT ); Tue, 7 Feb 2023 05:41:34 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE67338E87 for ; Tue, 7 Feb 2023 02:40:57 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so12834534wmb.2 for ; Tue, 07 Feb 2023 02:40:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F/upuEtRcIb7t8jvkFIGw73o4E9xTmHLpfwjgu7vvog=; b=xw6a313nqg5Vp68/k8JMPw+tYjF7bi9pacjL76AWkrjYhX+Rler2qrkyV0uEt8nzvn K/WGubh5JJ53381qBwcTKN7uXou4K3un/bPCLYKK8P+TO6iVo0K/rR9+SJuKnfuCmKqt vfkrj+yWRJfF+ZOOw6atQ6BotdDd4OKunjxwBn7C493WRS5ygMhiuVnXefqNZt7RAoDJ ktvypPe3pyI2w5ftH/dZRkcoOMbjqGbBCq0VDQ4T6Rg3pq7QXPYkKFMg8Wkn2MLA2Clv EdSrOLL9IqsdqlzK4juFevOmk974/ZlVwfET6wdR5vF9imwKGzSIMd7Iz0tb4S9kDj/4 fpGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F/upuEtRcIb7t8jvkFIGw73o4E9xTmHLpfwjgu7vvog=; b=J+aSY8ytdxV4eoWZqzekOL99YNMPiPDdYjyXh1dczxffTCsyBtwMdjcA6nq7s8cP3a qDm6FfMlOVCgIK/putDMcAL4VrzzOTDHe/pEoAqNSA5RhkqusYRM20Ey9/jWN4z/vIkH 7E1FxbVC5i/7NKQFjEabUKWlq5/IIHgdK3bY/87R7yozNhcLGVEJsHJLEJ/I7W2ot+mL IbIRhSjucsXzcFEt1kMnymJpdYHOjQZlTVDy2o/zeGgoAfEzwDsgnWCHtFLXYi049KZm hsOzzpN6CpgdQ76TsqQ6BIQG6KIsBtmaut+JnGVXYo7BvYXTSlYahxkizAV+sKCA/dK0 974g== X-Gm-Message-State: AO0yUKUsdrieXjgROjJW6tWa3M791HJmrBECM4ScHMUCPvzCMbLjyWUI 5bDjymLCeWxR5EtcMaym7irncA== X-Google-Smtp-Source: AK7set++tMAbtKYfer3K/a6e0NKT20sj2Nwd4RyicjOcCLQfigzIPlZVwOvPItlJKobUBErghQxVbA== X-Received: by 2002:a05:600c:4a9a:b0:3dc:46f6:e607 with SMTP id b26-20020a05600c4a9a00b003dc46f6e607mr2689936wmp.3.1675766453918; Tue, 07 Feb 2023 02:40:53 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id t6-20020a05600c198600b003dc492e4430sm14092696wmq.28.2023.02.07.02.40.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 02:40:53 -0800 (PST) Message-ID: Date: Tue, 7 Feb 2023 11:40:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] dt-bindings: mt76: add active-low property to led Content-Language: en-US To: Frank Wunderlich , linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230207102501.11418-1-linux@fw-web.de> From: Krzysztof Kozlowski In-Reply-To: <20230207102501.11418-1-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 07/02/2023 11:25, Frank Wunderlich wrote: > From: Frank Wunderlich > > LEDs can be in low-active mode, so add dt property for it. > > Signed-off-by: Frank Wunderlich > --- > .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml > index f0c78f994491..212508672979 100644 > --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml > @@ -112,6 +112,11 @@ properties: > $ref: /schemas/leds/common.yaml# > additionalProperties: false > properties: > + led-active-low: > + description: > + LED is enabled with ground signal. What does it mean? You set voltage of regulator to 0? Or you set GPIO as 0? If the latter, it's not the property of LED... Best regards, Krzysztof