From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9483636213D for ; Sat, 13 Jun 2026 09:22:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781342554; cv=none; b=lhEPrvDaKlobWTOpLsk9ljk1rYikeEJ1/OKORGPv8DUavnLL64PqCE1RnXDwmoPbQbUFDKDsGUJxxOPiKOGFSu572x6EBbbZZhpuyMBYFpKn9qC/FS99T6LveqaxIhs4sdYrQz+3N40Li16ul68llnJ+ThVTL7gOD25psSws9Uk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781342554; c=relaxed/simple; bh=helDrwuxiWtrf/iPIy4Y9R/hkLMVrwdS0rRl6C7Dn4Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VHhiyTt/Xmubh2pZk0ElJy/Uo5FmAtblohRR22x1dhCFCEiWgAEZV8c7CUCjR1X1IS2Ll30/6EuNACZ/BbDi7fvgvA3nzFI+gzsXenJA+a5wNpZElU6nskZSDEFbTbDKcNbId7bCx70EgRVuMi+MRXyBCgf01izp4gaLxjbTNL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XoqOW1/e; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UTNN6A5E; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XoqOW1/e"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UTNN6A5E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781342552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dkSlrlMGjyQ/p88XPP6jRxfxndrJ9//6XRAvhwfy0VE=; b=XoqOW1/et75dvB11HclyfE2WnENiZBvwch6nXEpzGWFw29SdKT8xDCRPruZrTgiIwG/E8k UJ207nbWddbHBtXKKo02I0d8XFoF58shDASVE11R0oQvteH7+Lt01TKS0xtXBpY4oIxNdY sqEm6P4CU1q9dwUYWeQqnPTocBLukeE= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-164-310d6vbtPdujzGqj6ig86Q-1; Sat, 13 Jun 2026 05:22:30 -0400 X-MC-Unique: 310d6vbtPdujzGqj6ig86Q-1 X-Mimecast-MFC-AGG-ID: 310d6vbtPdujzGqj6ig86Q_1781342550 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-915c364ae3bso343321485a.0 for ; Sat, 13 Jun 2026 02:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781342550; x=1781947350; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dkSlrlMGjyQ/p88XPP6jRxfxndrJ9//6XRAvhwfy0VE=; b=UTNN6A5EXmo5DGdbgZPJq3NzPGlloswBBYBt/V3SJFB3/ElFP+vrbiAK2xm5MolmSK NFmsD79pZaMdF3lp6/IwypUjIMA6OXGVTHeWFA8zxpU0yPuEMA+uqdjzWzz0joT2NJRs 598z3/9baZU5FJwl78/4iB5ZgorzMDFU0sD8wFIIHNGh0y+kC2nwEo8Gxx05L+JokBW9 wPOx7PzHZNtpHcTgjvhjflqX7MLTa9135cApqT7iHR+5QWJ+MPrBUV3ZQKLgikuWwF5z DRWj580+wy8wmKofPZnDHhbR9tbKilNXkPnmuRO9OVKYdJS6Kq/i0WJuoIW8wwg5bRcc 2HpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781342550; x=1781947350; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dkSlrlMGjyQ/p88XPP6jRxfxndrJ9//6XRAvhwfy0VE=; b=dXNXIjA6K3mEGbk25E2AiEnoNWzd1p2pbfDtGPpSyiokw5ecXeB7g1gX6zN/SK3jay hfUAhjNWnr6nnoWEMmF0/nuLGeypn95QZ3iBGrQ/zac8Orng1CasXvbD0DBVxPotRu+I PgHKYE2i68JaSBR8+E42YpLq/hGna7crzJzyLeVHdSb+GOyqh7FoOF+4ohdhUIVo86EL D5uOkIjjAW8oK58IWNvd6ckFBrzbtwZMS8Yyg3KRDtGuSfG0j0mIsoLkaTwdfUmHSH+l XVPsLqefu1G23H9FkZcYXs/ryRKP8vPoq72DNKqp7OjUPkeC2mXCusX3LxyuyRfFvBGV SeyA== X-Forwarded-Encrypted: i=1; AFNElJ8JJhkKCx4HssVk4WYm1St0t4w6I0sZy6cJ0Hv68gq1YXT2pAAe23t70SXp8t1rTDJM/8Ig+/Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwWBQR0pSjKRAkW+e1LH6dicGK38WJF9ebcoCvrFN29jlpKxVXv /h+trYxrRHDiVI/L0fV+NNuWiJyCTMVE9e2NoFhsNlCqazikU7JwNUaCAb1jsQMST54brz7QeUw J12G2wQzdRq9pNamQ1ZPEAUta4vFP/rqh65fEXqKg/U/AKnbbiKnoJ5iYTQ== X-Gm-Gg: Acq92OFaxzPcLIbaWCWu4w0D3Oz15W/LQ8jNjMem9BiPxUA6V8bBHkA5G78KM6BvJTd l7ymxrIAOnd6C40XnMFsIQdH7/jpbZioToJDoKMVHVYTU52kPPyXk3UBreTbWsPVaocGz29XxF2 HMIrN62xhdXd6EThcvnTAROlUOW5QQv6dCkgOOfpA565LVHIK3m8bYUoLEcTfvd/OuJcUJY6loh 5TWXn8PmHkHxzJXMuuJvt0IOI2Mbg+4y6RDEaYTgQ6XXvJ6i71LmXJ3xovzXFYPo/4GhayupA5A F2rA2RTxdGCpqHkZFS0a+6srN98in7im8J3WGqcU1WLVHb6uQ5l+neS7ZXma6p9pMnh9woVzDSR V1USmtexKRM+ywNsuTXQZnFd8w7Fyg6dKqpRDgx4QGzl82Vw3Ndqb8+Y= X-Received: by 2002:a05:620a:4708:b0:915:cf88:1e41 with SMTP id af79cd13be357-9161bf6c4bfmr926953585a.45.1781342549624; Sat, 13 Jun 2026 02:22:29 -0700 (PDT) X-Received: by 2002:a05:620a:4708:b0:915:cf88:1e41 with SMTP id af79cd13be357-9161bf6c4bfmr926950585a.45.1781342549179; Sat, 13 Jun 2026 02:22:29 -0700 (PDT) Received: from [192.168.88.32] ([150.228.25.72]) by smtp.gmail.com with ESMTPSA id af79cd13be357-91619f3c324sm454992285a.21.2026.06.13.02.22.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jun 2026 02:22:28 -0700 (PDT) Message-ID: Date: Sat, 13 Jun 2026 11:22:24 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 0/4] m68k: coldfire: fix non-standard readX()/writeX() functions To: Greg Ungerer , linux-m68k@lists.linux-m68k.org Cc: linux-kernel@vger.kernel.org, arnd@kernel.org, wei.fang@nxp.com, frank.li@nxp.com, shenwei.wang@nxp.com, imx@lists.linux.dev, netdev@vger.kernel.org, nico@fluxnic.net, adureghello@baylibre.com, ulfh@kernel.org, linux-mmc@vger.kernel.org, linux-can@vger.kernel.org, linux-spi@vger.kernel.org, olteanv@gmail.com References: <20260609142139.1563360-1-gerg@linux-m68k.org> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260609142139.1563360-1-gerg@linux-m68k.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/9/26 4:12 PM, Greg Ungerer wrote: > This odd collection of patches is aimed at fixing the non-standard ColdFire > set of readX()/writeX() IO access functions. Instead switching to using the > asm-generic definitions in include/asm-generic/io.h. The difficulty comes > in trying not to break any drivers with this change. > > The implementation of the readX()/writeX() family of IO access functions > is non-standard on ColdFire platforms. They either return big-endian (that > is native endian) data, or on platforms with PCI bus support check the > supplied address and return either big or little endian data based on that > check. This is non-standard, they are expected to always return > little-endian byte ordered data. Unfortunately this behavior also means > that ioreadX()/iowroteX() and their big-endian counter parts > ioreadXbe()/iowriteXbe() are currently broken because they are implemented > using the readX()/writeX() functions. > > Patches 1, 2 and 3 in this series are specific driver changes that can be > made independently of the final ColdFire readX()/writeX() change. > > Patch 4 is the actual switch to ColdFire building using asm-generic > readX()/writeX(), but also contains three driver fixes that are not easily > handled independently. > > Note that I don't have access to all supported hardware needed to fully > test all these changes. I have tested what I have, a bunch of the standard > Freescale ColdFire eval boards, and inspected generated code for differences. > > Note also that patch 3 relies on changes that are currently only in > linux-next, and are scheduled to hit mainline during the next v7.2 > merge window. Those changes are also available in an immutable git tree > at git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git > cf-internal-io branch. I understand that with this series you are targeting the m68K tree, am I correct? A possibly better option would be, after that the pre-req patches land into Linus's tree, to share an immutable branch for this series, so that both m68k and net-next could pull it. /P