From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
<andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
<jiri@resnulli.us>, <horms@kernel.org>, <David.Kaplan@amd.com>,
<dhowells@redhat.com>, Paul Menzel <pmenzel@molgen.mpg.de>,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH net v2 1/2] devlink: let driver opt out of automatic phys_port_name generation
Date: Mon, 11 Aug 2025 23:37:00 +0200 [thread overview]
Message-ID: <fe773700-40c4-486e-b9f6-5e2f2022596e@intel.com> (raw)
In-Reply-To: <c8473c7e-0432-481d-9db2-656c3ad7305b@intel.com>
On 8/11/25 23:27, Tony Nguyen wrote:
>
>
> On 8/8/2025 11:53 AM, Jakub Kicinski wrote:
>> On Tue, 5 Aug 2025 15:33:41 -0700 Tony Nguyen wrote:
>>> + if (devlink_port->attrs.no_phys_port_name)
>>> + return 0;
>>
>> Why are you returning 0 rather than -EOPNOTSUPP?
>> Driver which doesn't implement phys_port_name would normally return
>> -EOPNOTSUPP when user tries to read the sysfs file.
>
> Jedrek is out so I'm not sure the reason, but it does seem
> -EOPNOTSUPP would be more appropriate so I'll make that change.
when it was a driver callback, returning a 0 was short-circuiting
further (devlink) name computations
but in current form (v2), it is indeed better (at least wrt outcomes)
to return -EOPNOTSUPP, as that aligns with both sysfs and devlink output
so, good to update, thank you!
>
> Thanks,
> Tony
next prev parent reply other threads:[~2025-08-11 21:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 22:33 [PATCH net v2 0/2][pull request] ixgbe: bypass devlink phys_port_name generation Tony Nguyen
2025-08-05 22:33 ` [PATCH net v2 1/2] devlink: let driver opt out of automatic " Tony Nguyen
2025-08-08 18:52 ` Jakub Kicinski
2025-08-11 21:26 ` anthony.l.nguyen
2025-08-08 18:53 ` Jakub Kicinski
2025-08-11 21:27 ` Tony Nguyen
2025-08-11 21:32 ` Jacob Keller
2025-08-11 21:37 ` Przemek Kitszel [this message]
2025-08-05 22:33 ` [PATCH net v2 2/2] ixgbe: prevent from unwanted interface name changes Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe773700-40c4-486e-b9f6-5e2f2022596e@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=David.Kaplan@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jedrzej.jagielski@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).