From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [patch net-next 3/6] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls Date: Thu, 22 Sep 2016 09:12:10 -0600 Message-ID: References: <1474458794-5512-1-git-send-email-jiri@resnulli.us> <1474458794-5512-4-git-send-email-jiri@resnulli.us> <5206ebd6-89c1-ec44-8b98-c5109ebe6140@cumulusnetworks.com> <20160922150551.GE1830@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com, yotamg@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, linville@tuxdriver.com, andy@greyhouse.net, f.fainelli@gmail.com, jhs@mojatatu.com, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, ivecera@redhat.com, kaber@trash.net, john@phrozen.org To: Jiri Pirko Return-path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:36012 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934512AbcIVPMM (ORCPT ); Thu, 22 Sep 2016 11:12:12 -0400 Received: by mail-pa0-f53.google.com with SMTP id qn7so12774774pac.3 for ; Thu, 22 Sep 2016 08:12:12 -0700 (PDT) In-Reply-To: <20160922150551.GE1830@nanopsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: On 9/22/16 9:05 AM, Jiri Pirko wrote: > Thu, Sep 22, 2016 at 04:58:20PM CEST, dsa@cumulusnetworks.com wrote: >> On 9/21/16 5:53 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Until now, in order to offload a FIB entry to HW we use switchdev op. >>> However that has limits. Mainly in case we need to make the HW aware of >>> all route prefixes configured in kernel. HW needs to know those in order >>> to properly trap appropriate packets and pass the to kernel to do >>> the forwarding. Abort mechanism is now handled within the mlxsw driver. >>> >>> Signed-off-by: Jiri Pirko >>> --- >>> drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 9 +- >>> .../net/ethernet/mellanox/mlxsw/spectrum_router.c | 386 ++++++++++++--------- >>> .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 9 - >>> 3 files changed, 216 insertions(+), 188 deletions(-) >>> >>> >> >> >> Make the move to fib notifiers and the removal of switchdev code separate patches. It will make the fib notifier change easier to follow. > > Since I'm changing one iface by another, I don't see how I can split it. > Make the previous API dead and remove it in a separate patch. The init/fini code changes -- just a code move, no logical changes? then make it a separate patch - or don't move it at all and just add prototypes. Some important code blocks are hard to read through the diffs as they are now.