* [PATCH] net: wan/fsl_ucc_hdlc: cleanup ucc_hdlc_poll
@ 2026-03-26 10:02 Tomas Alvarez Vanoli
2026-03-26 12:17 ` Christophe Leroy (CS GROUP)
0 siblings, 1 reply; 2+ messages in thread
From: Tomas Alvarez Vanoli @ 2026-03-26 10:02 UTC (permalink / raw)
To: netdev, linuxppc-dev; +Cc: qiang.zhao, andrew+netdev, Tomas Alvarez Vanoli
Immediately after setting to 0 we are adding to it, and subtracting 0
from budget. Replace with just assignment and no subtraction.
Signed-off-by: Tomas Alvarez Vanoli <tomas.alvarez-vanoli@hitachienergy.com>
---
drivers/net/wan/fsl_ucc_hdlc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index b72ab9951875e..3bd57527b1be6 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -628,8 +628,7 @@ static int ucc_hdlc_poll(struct napi_struct *napi, int budget)
hdlc_tx_done(priv);
spin_unlock(&priv->lock);
- howmany = 0;
- howmany += hdlc_rx_done(priv, budget - howmany);
+ howmany = hdlc_rx_done(priv, budget);
if (howmany < budget) {
napi_complete_done(napi, howmany);
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: wan/fsl_ucc_hdlc: cleanup ucc_hdlc_poll
2026-03-26 10:02 [PATCH] net: wan/fsl_ucc_hdlc: cleanup ucc_hdlc_poll Tomas Alvarez Vanoli
@ 2026-03-26 12:17 ` Christophe Leroy (CS GROUP)
0 siblings, 0 replies; 2+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-03-26 12:17 UTC (permalink / raw)
To: Tomas Alvarez Vanoli, netdev, linuxppc-dev; +Cc: qiang.zhao, andrew+netdev
Le 26/03/2026 à 11:02, Tomas Alvarez Vanoli a écrit :
> Immediately after setting to 0 we are adding to it, and subtracting 0
> from budget. Replace with just assignment and no subtraction.
>
> Signed-off-by: Tomas Alvarez Vanoli <tomas.alvarez-vanoli@hitachienergy.com>
Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
> ---
> drivers/net/wan/fsl_ucc_hdlc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
> index b72ab9951875e..3bd57527b1be6 100644
> --- a/drivers/net/wan/fsl_ucc_hdlc.c
> +++ b/drivers/net/wan/fsl_ucc_hdlc.c
> @@ -628,8 +628,7 @@ static int ucc_hdlc_poll(struct napi_struct *napi, int budget)
> hdlc_tx_done(priv);
> spin_unlock(&priv->lock);
>
> - howmany = 0;
> - howmany += hdlc_rx_done(priv, budget - howmany);
> + howmany = hdlc_rx_done(priv, budget);
>
> if (howmany < budget) {
> napi_complete_done(napi, howmany);
> --
> 2.47.3
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-26 12:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-26 10:02 [PATCH] net: wan/fsl_ucc_hdlc: cleanup ucc_hdlc_poll Tomas Alvarez Vanoli
2026-03-26 12:17 ` Christophe Leroy (CS GROUP)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox