From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9FCDC433E0 for ; Sun, 14 Feb 2021 01:07:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4F7964E39 for ; Sun, 14 Feb 2021 01:07:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229864AbhBNBHM (ORCPT ); Sat, 13 Feb 2021 20:07:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229694AbhBNBHH (ORCPT ); Sat, 13 Feb 2021 20:07:07 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3710C061574 for ; Sat, 13 Feb 2021 17:06:26 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id i20so2943681otl.7 for ; Sat, 13 Feb 2021 17:06:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DRXHRCkxzERrs38qCs7uphlsqeR6aJRlRvcvPhsKWsg=; b=DIL0j5eRFMqCUzlhrs/3pdGwGldHRCVjROmb9DjkIYjPdSyL0uWk565I6Fu6YnTpKX C89M3yhTojen17owMBTzy927b2v0SaM9zsD9pxEhY55FJ4j59Ji0vX630c+8ehP7CbMV CRKUUZ469huW1kvow7RHfVQlkuk7h6akNQ5MzrZmKTCqcha2/PZr1WNPXP1cXo4IDgKC xN6k73XWanlh8mKpmyUcf4R7oMtKmyliv1gtvdQavwJzBNIEaT/l235JSDlwq+lPlQTM 0vZfMttnRnWhpTEAu1xjs/PizfbJq+IoXjLIr7uy4GD6DkSKkoVpLyDHZVg8VoBtBvoD NBew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DRXHRCkxzERrs38qCs7uphlsqeR6aJRlRvcvPhsKWsg=; b=IIbcETGXKlrWVqlUcFF5KN7I01zltBuPa4ghVKGwe+WWVAOP+E6SeuwgOFH8Taqmci qMSQoogvP+oTrd0/3llELEJUdUxo7ucsphcEe3XZejYWfB9bDMRkPHpFEumPcB/uGG2D xjK9Nk4nVxiAC4Qw9ggS2LBaOrS8lWTWyoBiwbcZfBSkl+tZP6E5i2loCO02uhDZ+jRV reUyFLyG4C8hnCl5+PAbsfp+4G+GjMyu+u35OWnnWlqzHkvfsEZ39U/8YqrN2Nccikrw hbAR8iTdkq2+zSPAMdPIpPRqeVuV/E4j2WFXbU8iU1HfjvJbboHuIVbLi+ZQzWAM/BvH 1VyA== X-Gm-Message-State: AOAM530Zr1WlBxQSchRiaUQax5fbewwYMD00vw98UtgPqxzMti/aQnoG 1npDDumvCu+SduYPYo380Ik= X-Google-Smtp-Source: ABdhPJxGHQ8vVd1nFCGLXtb3IJGaKJLmN7BToncgiXI4uHuU0fueUwDeQsf+b5PndvHsQYQlaDRPXQ== X-Received: by 2002:a9d:75d0:: with SMTP id c16mr7163463otl.261.1613264786231; Sat, 13 Feb 2021 17:06:26 -0800 (PST) Received: from ?IPv6:2600:1700:dfe0:49f0:e93c:cbea:e191:f62a? ([2600:1700:dfe0:49f0:e93c:cbea:e191:f62a]) by smtp.gmail.com with ESMTPSA id h24sm2586222otl.50.2021.02.13.17.06.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Feb 2021 17:06:25 -0800 (PST) Subject: Re: [PATCH net-next 2/5] net: bridge: propagate extack through store_bridge_parm To: Vladimir Oltean , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Andrew Lunn , Vivien Didelot , Kurt Kanzenbach , Woojung Huh , Linus Walleij , Hauke Mehrtens , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , DENG Qingfang , Ido Schimmel References: <20210213204319.1226170-1-olteanv@gmail.com> <20210213204319.1226170-3-olteanv@gmail.com> From: Florian Fainelli Message-ID: Date: Sat, 13 Feb 2021 17:06:22 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210213204319.1226170-3-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/13/2021 12:43, Vladimir Oltean wrote: > From: Vladimir Oltean > > The bridge sysfs interface stores parameters for the STP, VLAN, > multicast etc subsystems using a predefined function prototype. > Sometimes the underlying function being called supports a netlink > extended ack message, and we ignore it. > > Let's expand the store_bridge_parm function prototype to include the > extack, and just print it to console, but at least propagate it where > applicable. Where not applicable, create a shim function in the > br_sysfs_br.c file that discards the extra function argument. > > This patch allows us to propagate the extack argument to > br_vlan_set_default_pvid, br_vlan_set_proto and br_vlan_filter_toggle, > and from there, further up in br_changelink from br_netlink.c. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian