From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66385C43381 for ; Sun, 17 Feb 2019 08:14:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B7092192D for ; Sun, 17 Feb 2019 08:14:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cqcj2602" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727213AbfBQIOl (ORCPT ); Sun, 17 Feb 2019 03:14:41 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:56316 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbfBQIOl (ORCPT ); Sun, 17 Feb 2019 03:14:41 -0500 Received: by mail-wm1-f68.google.com with SMTP id q187so1883700wme.5 for ; Sun, 17 Feb 2019 00:14:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Qs1VfT1V7B440XQIW0CYqIojuNKViMJMhHALMqPy6kU=; b=cqcj2602ib+CU9ZGFXvQXiVoFSzkl3sTTFlaFcyE7rIudma9vOABaFX4ywZpX7kT6I ypuG6p1HalZ57WEgAnSohdYqO4H/Gl3UmDZX9wV1C843HVAWQCYF9ozlBqBJt41n0rMu TTmBEABmkGle3qhgZGm2QiN7gKWuYR6WHrd81vzUw+MQyb13bvAeb26jGplAo1Q3Ncdx tNmaUBU43Qz/xEYIsDkrRZE8wLQ18bJCpoetiXJPx0oNWME8vaTCtIq+VAAx+NwKjHhi HwDsK1p8Mjsdfyun1p8sGCIfOsbkLYDsBlaV5pKgzHfPZ/xwx+zpajENAOZYviMCwbdi zkGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Qs1VfT1V7B440XQIW0CYqIojuNKViMJMhHALMqPy6kU=; b=hIihjNg2M7sLu5p4Xxb2mBqxGQAKVDBTgFKzbSV41VNWoFzECf6mLMp4u52mOtqvSF AnXTwJRcfwlpzScllissjZovl8K+MSYhkgpJF2v2u8kDxhlizb9sKYQGMFXnIDE+xfgD JWJkFXLC174hAXPLiqtvdVuPOf8yccIu2JXY14R0fLEPsHYl36PDJwKrqdDXUhWrg6E/ aq/kcHRRixzHDkxeObG+ZqRIFzO/GXf4Rb6vqDZpHE8LSP4nF/WC4kceVsEl607Z6dXu wEZRmHop+vQLFuj1qT7x4heH5Eu11ot4jiiZDYhag7zwR/JdnYqHsY0Pyug4ghDGV4eD ofIg== X-Gm-Message-State: AHQUAubYuIBiMk8SprqAruH2AiUyZkk8uov1uMmyukJpiPsd36Ehcf/W hY6MO36aWE/QM2mkolkG4fC420uL X-Google-Smtp-Source: AHgI3IYhANIiVY+AcyaFoSaZ5tKYNbo44umfrZl3BEmWvh5k2GEN8BQP2M1Do56XWMTmEajG30V0Fg== X-Received: by 2002:a1c:44c3:: with SMTP id r186mr12171858wma.63.1550391279038; Sun, 17 Feb 2019 00:14:39 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:4c36:c930:69b6:c10f? (p200300EA8BF1E2004C36C93069B6C10F.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:4c36:c930:69b6:c10f]) by smtp.googlemail.com with ESMTPSA id 62sm22312193wra.46.2019.02.17.00.14.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 00:14:38 -0800 (PST) Subject: Re: [PATCH net-next 2/4] net: phy: add genphy_c45_an_config_an To: Andrew Lunn , Florian Fainelli Cc: David Miller , Russell King - ARM Linux , "netdev@vger.kernel.org" References: <0423e795-0215-053f-57ff-386242a6d7ce@gmail.com> <407e490f-17f6-c9a5-a128-9a27a3230c39@gmail.com> <20190217041833.GU5699@lunn.ch> From: Heiner Kallweit Message-ID: Date: Sun, 17 Feb 2019 09:14:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190217041833.GU5699@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 17.02.2019 05:18, Andrew Lunn wrote: > On Sat, Feb 16, 2019 at 06:44:24PM -0800, Florian Fainelli wrote: >> >> >> On 2/16/2019 11:51 AM, Heiner Kallweit wrote: >>> From: Andrew Lunn >>> C45 configuration of 10/100 and multi-giga bit auto negotiation >>> advertisement is standardized. Configuration of 1000Base-T however >>> appears to be vendor specific. Move the generic code out of the >>> Marvell driver into the common phy-c45.c file. >>> >>> Signed-off-by: Andrew Lunn >>> [hkallweit1@gmail.com: use new helper linkmode_adv_to_mii_10gbt_adv_t and split patch] >>> Signed-off-by: Heiner Kallweit >>> --- >>> drivers/net/phy/phy-c45.c | 44 +++++++++++++++++++++++++++++++++++++++ >>> include/linux/phy.h | 1 + >>> 2 files changed, 45 insertions(+) >>> >>> diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c >>> index 0374c50b1..bea1b0c6e 100644 >>> --- a/drivers/net/phy/phy-c45.c >>> +++ b/drivers/net/phy/phy-c45.c >>> @@ -78,6 +78,50 @@ int genphy_c45_pma_setup_forced(struct phy_device *phydev) >>> } >>> EXPORT_SYMBOL_GPL(genphy_c45_pma_setup_forced); >>> >>> +/** >>> + * genphy_c45_an_config_an - configure advertisement registers >> >> Nit: are not the two "an" redundant" here? Unless the first one means >> something different in which case naming this: >> genphy_c45_an_config_aneg() would be clearer? > > Hi Florian > > Heiner and I had a brief discussion about this. There is a general > trend in the naming to have the device name in the function name. So > genphy_c45_pma_setup_forced uses the PMA device registers, > genphy_c45_an_disable_aneg uses the AN device registers, etc. > > However, genphy_c45_an_config_aneg() might be better. > Good, then I'll prepare an update with the changed name. > Andrew > Heiner