From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default Date: Fri, 25 May 2018 13:33:59 +0300 Message-ID: References: <20180524120300.15829-1-sw@simonwunderlich.de> <20180524120300.15829-3-sw@simonwunderlich.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, Sven Eckelmann To: Simon Wunderlich , davem@davemloft.net Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:39034 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965651AbeEYKeA (ORCPT ); Fri, 25 May 2018 06:34:00 -0400 Received: by mail-wm0-f66.google.com with SMTP id f8-v6so13299186wmc.4 for ; Fri, 25 May 2018 03:34:00 -0700 (PDT) In-Reply-To: <20180524120300.15829-3-sw@simonwunderlich.de> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hello! On 5/24/2018 3:02 PM, Simon Wunderlich wrote: > From: Sven Eckelmann > > All tools which were known to the batman-adv development team are > supporting the batman-adv netlink interface since a while. Also debugfs is > not supported for batman-adv interfaces in any non-default netns. Thus > disabling CONFIG_BATMAN_ADV_DEBUGFS by default should not cause problems on > most systems. It is still possible to enable it in case it is still > required in a specific setup. > > Signed-off-by: Sven Eckelmann > Signed-off-by: Simon Wunderlich > --- > net/batman-adv/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig > index e4e2e02b7380..bee034a95208 100644 > --- a/net/batman-adv/Kconfig > +++ b/net/batman-adv/Kconfig > @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > bool "batman-adv debugfs entries" > depends on BATMAN_ADV > depends on DEBUG_FS > - default y > + default n N is the default default. :-) You don't need this line. [...] MBR, Sergei