From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60F7CC43381 for ; Thu, 28 Mar 2019 02:51:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 270172075E for ; Thu, 28 Mar 2019 02:51:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HcBl6JOK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727928AbfC1CuX (ORCPT ); Wed, 27 Mar 2019 22:50:23 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:36416 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbfC1CuW (ORCPT ); Wed, 27 Mar 2019 22:50:22 -0400 Received: by mail-pl1-f196.google.com with SMTP id k2so4243342plt.3 for ; Wed, 27 Mar 2019 19:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=D6xRbtshCMfUpPTFC5Wnyrv2zO7YJBHBclwyRuiZNhY=; b=HcBl6JOKl3xuvNrexqJu+sX5md4usdGdQJvh8VyaQMCma94qQtBjFVElUe7VgJ3V1H aSt25jGtlR7OqPOVP7R0YlbymTX7AyRk/1RubU0Qo62A3nt/WiO6Ye6UP1ziuzzobzm/ ltqe+a0XxrRZni4XFOw8KrFMNWzSNSdi6rCW7Xyhl109rm4rAISlnSdi5m/jJ+dLFMFz 5STGpA5Rt0tzNNlz0tepKMmY5jjrS1witbFBbmcw3n8mtLh7SxaL8LJ2+29xqo/OAtWN fmgsAXXRVr+FaJbCyygrIJ6ns32QTXwI+0Cjd8q/vqBN9GjVYC67jHKMdcGHwgPCgfUN PzNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=D6xRbtshCMfUpPTFC5Wnyrv2zO7YJBHBclwyRuiZNhY=; b=ijnSEOfXtGSe22gHwbMD+TmpdQfQGfui0zFeQR26OF1I9qrYRUQ4H9LO6ybJvTnFWo 9HJjQXONuW+6U1tSo/vwXsm6s0Wu2WguP4OAR3tP8m0Dm4jzANS0vkRCweaHLEeEr7xB Qt3Ia20SjDWy/kpnBRzoLBQKDNhWWtUjMA3RFgkKm7I+TxREoqpBnMju1Bk14sXSoTb1 u9u1sKz0Q19EzNYMOHyNKCWAXAiYS3uLQvD6G6yqwaVq0QZqtOm1wv4OcaBf//ibyWnH lsGYMPbLQRjkzfowJQzHGYboWXgIHtA5HrizVxXgpMSls2Bm/Blxol70FUa18J43xZ0x 2eqw== X-Gm-Message-State: APjAAAXU5+CrvYEQJqV7aCtJru8JoV68sS3x8FWiSBX1qpuMRJdFBZah 3n9XQsr5XLeqCWltQbCcQk0= X-Google-Smtp-Source: APXvYqzYPxxbOMApR86o0HbwXBS4xiIEnyridsik+RIh+ZYFPHvCFgVbdMSGQG2CcTlUBWF7gJq0vA== X-Received: by 2002:a17:902:e709:: with SMTP id co9mr17359341plb.86.1553741422424; Wed, 27 Mar 2019 19:50:22 -0700 (PDT) Received: from ?IPv6:2601:284:8200:5cfb:3c44:c5bd:e28a:98ee? ([2601:284:8200:5cfb:3c44:c5bd:e28a:98ee]) by smtp.googlemail.com with ESMTPSA id c134sm34664712pfc.87.2019.03.27.19.50.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 19:50:21 -0700 (PDT) Subject: Re: [PATCH v2 net-next 05/13] ipv6: Create init helper for fib6_nh To: Alexei Starovoitov Cc: David Ahern , davem@davemloft.net, netdev@vger.kernel.org, idosch@mellanox.com, jiri@mellanox.com, saeedm@mellanox.com References: <20190327182329.18149-1-dsahern@kernel.org> <20190327182329.18149-6-dsahern@kernel.org> <20190327225210.kbpivej33a72adwq@ast-mbp> <8e0e2afc-c8e7-8728-7b4d-f9c64987d46a@gmail.com> <20190328013051.cukjdmcfdc5gmxnv@ast-mbp> <51a3d3fa-e0c1-ca40-8c25-659487a092f7@gmail.com> <20190328022949.rolbfyk5bkcib3jr@ast-mbp> From: David Ahern Message-ID: Date: Wed, 27 Mar 2019 20:50:19 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190328022949.rolbfyk5bkcib3jr@ast-mbp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/27/19 8:29 PM, Alexei Starovoitov wrote:]\ > that was a typo. I meant fib6_flags. > why mess with cfg and use it as weird side effect only to > get rt->fib6_flags = cfg->fc_flags; working after fib6_nh_init() returns? > Why not to move that fib6_flags = fc_flags assignment into fib6_nh_init ? > Then cfg can stay constant and no weird side effects from init function. > Because fib6_flags is not a nh_init argument and it should not be. I will duplicate that check to appease your request of not touching cfg->flags.