From: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
To: Tom Seewald <tseewald@gmail.com>, netdev@vger.kernel.org
Cc: Auke Kok <auke-jan.h.kok@intel.com>,
Jeff Garzik <jeff@garzik.org>, Jakub Kicinski <kuba@kernel.org>,
intel-wired-lan@lists.osuosl.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net 1/2] e1000e: Fix duplicate include guard
Date: Tue, 2 Mar 2021 09:55:14 +0200 [thread overview]
Message-ID: <fedcd02f-d3d3-763f-0032-dc68ca166a3c@linux.intel.com> (raw)
In-Reply-To: <20210222040005.20126-1-tseewald@gmail.com>
On 22/02/2021 06:00, Tom Seewald wrote:
> The include guard "_E1000_HW_H_" is used by header files in three
> different drivers (e1000/e1000_hw.h, e1000e/hw.h, and igb/e1000_hw.h).
> Using the same include guard macro in more than one header file may
> cause unexpected behavior from the compiler. Fix the duplicate include
> guard in the e1000e driver by renaming it.
>
> Fixes: bc7f75fa9788 ("[E1000E]: New pci-express e1000 driver (currently for ICH9 devices only)")
> Signed-off-by: Tom Seewald <tseewald@gmail.com>
> ---
> drivers/net/ethernet/intel/e1000e/hw.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/hw.h b/drivers/net/ethernet/intel/e1000e/hw.h
> index 69a2329ea463..db79c4e6413e 100644
> --- a/drivers/net/ethernet/intel/e1000e/hw.h
> +++ b/drivers/net/ethernet/intel/e1000e/hw.h
> @@ -1,8 +1,8 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> /* Copyright(c) 1999 - 2018 Intel Corporation. */
>
> -#ifndef _E1000_HW_H_
> -#define _E1000_HW_H_
> +#ifndef _E1000E_HW_H_
> +#define _E1000E_HW_H_
>
> #include "regs.h"
> #include "defines.h"
> @@ -714,4 +714,4 @@ struct e1000_hw {
> #include "80003es2lan.h"
> #include "ich8lan.h"
>
> -#endif
> +#endif /* _E1000E_HW_H_ */
>
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
next prev parent reply other threads:[~2021-03-02 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 4:00 [PATCH net 1/2] e1000e: Fix duplicate include guard Tom Seewald
2021-02-22 4:00 ` [PATCH net 2/2] igb: " Tom Seewald
2021-02-26 22:30 ` Jesse Brandeburg
2021-03-02 7:55 ` Dvora Fuxbrumer [this message]
2021-03-02 8:29 ` [Intel-wired-lan] [PATCH net 1/2] e1000e: " Neftin, Sasha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fedcd02f-d3d3-763f-0032-dc68ca166a3c@linux.intel.com \
--to=dvorax.fuxbrumer@linux.intel.com \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeff@garzik.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tseewald@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).