From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF70DC43381 for ; Sun, 3 Mar 2019 17:41:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FB3B20866 for ; Sun, 3 Mar 2019 17:41:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="th8fLxPc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726587AbfCCRld (ORCPT ); Sun, 3 Mar 2019 12:41:33 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:53352 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726416AbfCCRld (ORCPT ); Sun, 3 Mar 2019 12:41:33 -0500 Received: by mail-wm1-f68.google.com with SMTP id e74so2481126wmg.3 for ; Sun, 03 Mar 2019 09:41:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8BL+SvwkUGVh1a2MOJAuYc8w8/zKiIphDKVUiu7quQQ=; b=th8fLxPc/tdyuzTZYh8T54orSJOvvAWCvPwVfapdTSnjSAONFSPely49fMBk2bbIiu kcOS7T8M8Uezg83cd5Rp9ce4Do5BZ4/nl4pyToh0Jr7rtkbjda+2T31AnGXObPMqXoi3 B9ibXe54pS4D8G1XbGybRxe5auGn4uGMZf64meESUSUgAP5Z4EKe+GERPrLdd4SRNOou +i9rhBrnlvSCPooyAFJV3vHEsYous8P4w1HDdb2L9bPwoEi1igaOqb2EuZRNW/xSP9A2 DEdqLK3lcPaDWeNI1oVnHiuLnyILcvQ1Z3ZzK/eE9AnJH0YdCnbuZScn36Noe87XtZjs ggBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8BL+SvwkUGVh1a2MOJAuYc8w8/zKiIphDKVUiu7quQQ=; b=ujb+wAVbeO8a2kwmhRCVlnNrwLMeOdrEjlx5R0sdEiksaI/wY+X0lfxFyaJ2MU/8sf atgXGKqq6w1sJaq7AalZ71qIMwtSSQf68V86gi9MRTmi+VUgIdkx8wn7Nd/NnvmHhELH KNA2qTus7ELpZqx0osQySiOvBfKu3LHn+Yf80RxHgw7bN3N7AorT9daPFsvao3OhOQGL bvZmTjjBqAJGAtU2eybY66rkJnmdklvxC7M9rJzDxX8u89J+Rq+ylygaIl+4q8Y81kOV gLRp3eMaz3/W4ucAYgFJfzx1BpSQwlDy1h8R3UH3cRH190XEc8icDQUDkWAUmiXK3x14 VAUg== X-Gm-Message-State: APjAAAWxUr2bV+fhN8SRRvTyXD3fk438e89WSoVNT0dS0FpYRa4M8Trr NXHZhJAOhBiqPRBxnoDVTK2DdDcH X-Google-Smtp-Source: APXvYqyhZkygS5/vxYcqxZuj6CnL1za+SZVARQJAi2ZHDKR6zurojQRErXZ7bQOpRzAR7T307jgNbA== X-Received: by 2002:a1c:cf41:: with SMTP id f62mr3262813wmg.1.1551634891112; Sun, 03 Mar 2019 09:41:31 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:35a8:f48d:4b19:96c9? (p200300EA8BF1E20035A8F48D4B1996C9.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:35a8:f48d:4b19:96c9]) by smtp.googlemail.com with ESMTPSA id f6sm4666360wrs.45.2019.03.03.09.41.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Mar 2019 09:41:30 -0800 (PST) Subject: Re: [PATCH net-next 2/2] net: phy: aquantia: use new function strreplace_nonalnum To: Andrew Lunn Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <42f2e064-181c-087e-68b1-64d2d6f13e0e@gmail.com> <20190303173135.GH11621@lunn.ch> From: Heiner Kallweit Message-ID: Date: Sun, 3 Mar 2019 18:41:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190303173135.GH11621@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03.03.2019 18:31, Andrew Lunn wrote: > On Sun, Mar 03, 2019 at 06:21:53PM +0100, Heiner Kallweit wrote: >> Use new function strreplace_nonalnum to simplify the code. > > Hi Heiner > > Both Marvell PHY drivers could use this. > > sfp.c has a variant of this as well. > Thanks! My plan was to provide a first user so that the new function gets accepted, and then look for more places where it could be used. Most likely there are few HWMON drivers also open-coding this functionality. > Andrew > Heiner