Re: [PATCH net-next v17 02/14] net: Make dev_get_hwtstamp_phylib accessible

[Jacob Keller <jacob.e.keller@intel.com>]

On 7/9/2024 6:53 AM, Kory Maincent wrote:
> Make the dev_get_hwtstamp_phylib function accessible in prevision to use
> it from ethtool to read the hwtstamp current configuration.
> 
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Change in v8:
> - New patch
> 
> Change in v10:
> - Remove export symbol as ethtool can't be built as a module.
> - Move the declaration to net/core/dev.h instead of netdevice.h
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  net/core/dev.h       | 2 ++
>  net/core/dev_ioctl.c | 4 ++--
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/net/core/dev.h b/net/core/dev.h
> index 5654325c5b71..9d4ceaf9bdc0 100644
> --- a/net/core/dev.h
> +++ b/net/core/dev.h
> @@ -187,5 +187,7 @@ static inline void dev_xmit_recursion_dec(void)
>  int dev_set_hwtstamp_phylib(struct net_device *dev,
>  			    struct kernel_hwtstamp_config *cfg,
>  			    struct netlink_ext_ack *extack);
> +int dev_get_hwtstamp_phylib(struct net_device *dev,
> +			    struct kernel_hwtstamp_config *cfg);
>  
>  #endif
> diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c
> index b9719ed3c3fd..b8cf8c55fa2d 100644
> --- a/net/core/dev_ioctl.c
> +++ b/net/core/dev_ioctl.c
> @@ -268,8 +268,8 @@ static int dev_eth_ioctl(struct net_device *dev,
>   * -EOPNOTSUPP for phylib for now, which is still more accurate than letting
>   * the netdev handle the GET request.
>   */
> -static int dev_get_hwtstamp_phylib(struct net_device *dev,
> -				   struct kernel_hwtstamp_config *cfg)
> +int dev_get_hwtstamp_phylib(struct net_device *dev,
> +			    struct kernel_hwtstamp_config *cfg)
>  {
>  	if (phy_has_hwtstamp(dev->phydev))
>  		return phy_hwtstamp_get(dev->phydev, cfg);
>