From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH v2 1/1] tools/lib/libbpf.c: fix string format to allow build on arm32 Date: Wed, 23 May 2018 20:19:24 +0200 Message-ID: References: <20180523161704.4f5af2ehqdh6cqrh@vm4> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org To: Sirio Balmelli Return-path: Received: from www62.your-server.de ([213.133.104.62]:50887 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754658AbeEWST0 (ORCPT ); Wed, 23 May 2018 14:19:26 -0400 In-Reply-To: <20180523161704.4f5af2ehqdh6cqrh@vm4> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/23/2018 06:17 PM, Sirio Balmelli wrote: > On arm32, 'cd tools/testing/selftests/bpf && make' fails with: > > libbpf.c:80:10: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘int64_t {aka long long int}’ [-Werror=format=] > (func)("libbpf: " fmt, ##__VA_ARGS__); \ > ^ > libbpf.c:83:30: note: in expansion of macro ‘__pr’ > #define pr_warning(fmt, ...) __pr(__pr_warning, fmt, ##__VA_ARGS__) > ^~~~ > libbpf.c:1072:3: note: in expansion of macro ‘pr_warning’ > pr_warning("map:%s value_type:%s has BTF type_size:%ld != value_size:%u\n", > > To fix, typecast 'key_size' and amend format string. > > Signed-off-by: Sirio Balmelli Applied to bpf-next, thank Sirio!