* [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count
@ 2016-11-27 20:43 Andreas Färber
2016-11-27 21:22 ` Andrew Lunn
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2016-11-27 20:43 UTC (permalink / raw)
To: netdev
Cc: linux-arm-kernel, Uwe Kleine-König, Michal Hrusecki,
Tomas Hlavacek, Bedřicha Košatu, Andreas Färber,
Andrew Lunn, Vivien Didelot, Florian Fainelli, linux-kernel
mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings,
so free the same amount. This will be 8 or 9 in practice, less than 16.
Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.")
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 98302358ceb9..95b9efb33ec7 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -421,7 +421,7 @@ static void mv88e6xxx_g1_irq_free(struct mv88e6xxx_chip *chip)
free_irq(chip->irq, chip);
- for (irq = 0; irq < 16; irq++) {
+ for (irq = 0; irq < chip->g1_irq.nirqs; irq++) {
virq = irq_find_mapping(chip->g1_irq.domain, irq);
irq_dispose_mapping(virq);
}
--
2.6.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count
2016-11-27 20:43 [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count Andreas Färber
@ 2016-11-27 21:22 ` Andrew Lunn
2016-11-27 21:32 ` Andreas Färber
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Lunn @ 2016-11-27 21:22 UTC (permalink / raw)
To: Andreas Färber
Cc: netdev, linux-arm-kernel, Uwe Kleine-König, Michal Hrusecki,
Tomas Hlavacek, Bed??icha Ko??atu, Vivien Didelot,
Florian Fainelli, linux-kernel
On Sun, Nov 27, 2016 at 09:43:44PM +0100, Andreas Färber wrote:
> mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings,
> so free the same amount. This will be 8 or 9 in practice, less than 16.
Hi Andreas
The patch is correct, but please read
Documentation/networking/netdev-FAQ.txt
and then resubmit the patch.
Andrew
>
> Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.")
> Cc: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index 98302358ceb9..95b9efb33ec7 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -421,7 +421,7 @@ static void mv88e6xxx_g1_irq_free(struct mv88e6xxx_chip *chip)
>
> free_irq(chip->irq, chip);
>
> - for (irq = 0; irq < 16; irq++) {
> + for (irq = 0; irq < chip->g1_irq.nirqs; irq++) {
> virq = irq_find_mapping(chip->g1_irq.domain, irq);
> irq_dispose_mapping(virq);
> }
> --
> 2.6.6
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count
2016-11-27 21:22 ` Andrew Lunn
@ 2016-11-27 21:32 ` Andreas Färber
2016-11-27 21:39 ` Andrew Lunn
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2016-11-27 21:32 UTC (permalink / raw)
To: Andrew Lunn
Cc: netdev, linux-arm-kernel, Uwe Kleine-König, Michal Hrusecki,
Tomas Hlavacek, Bed??icha Ko??atu, Vivien Didelot,
Florian Fainelli, linux-kernel
Hi Andrew,
Am 27.11.2016 um 22:22 schrieb Andrew Lunn:
> On Sun, Nov 27, 2016 at 09:43:44PM +0100, Andreas Färber wrote:
>> mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings,
>> so free the same amount. This will be 8 or 9 in practice, less than 16.
>
> Hi Andreas
>
> The patch is correct, but please read
> Documentation/networking/netdev-FAQ.txt
> and then resubmit the patch.
Do you mean --subject-prefix="PATCH net-next" or something else?
Thanks,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count
2016-11-27 21:32 ` Andreas Färber
@ 2016-11-27 21:39 ` Andrew Lunn
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2016-11-27 21:39 UTC (permalink / raw)
To: Andreas Färber
Cc: netdev, linux-arm-kernel, Uwe Kleine-König, Michal Hrusecki,
Tomas Hlavacek, Bed??icha Ko??atu, Vivien Didelot,
Florian Fainelli, linux-kernel
On Sun, Nov 27, 2016 at 10:32:41PM +0100, Andreas Färber wrote:
> Hi Andrew,
>
> Am 27.11.2016 um 22:22 schrieb Andrew Lunn:
> > On Sun, Nov 27, 2016 at 09:43:44PM +0100, Andreas Färber wrote:
> >> mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings,
> >> so free the same amount. This will be 8 or 9 in practice, less than 16.
> >
> > Hi Andreas
> >
> > The patch is correct, but please read
> > Documentation/networking/netdev-FAQ.txt
> > and then resubmit the patch.
>
> Do you mean --subject-prefix="PATCH net-next"
Yep.
Thanks
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-27 21:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-27 20:43 [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count Andreas Färber
2016-11-27 21:22 ` Andrew Lunn
2016-11-27 21:32 ` Andreas Färber
2016-11-27 21:39 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).