From: Heiner Kallweit <hkallweit1@gmail.com>
To: "S-k, Shyam-sundar" <Shyam-sundar.S-k@amd.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>
Subject: Re: net-next: new CL45 regression
Date: Tue, 5 Mar 2019 07:58:34 +0100 [thread overview]
Message-ID: <ff23c988-f724-df6b-ea23-be74ff33de1c@gmail.com> (raw)
In-Reply-To: <4f0da0bb-5a17-8802-9f38-ffa9f7cb3d19@amd.com>
On 05.03.2019 04:07, S-k, Shyam-sundar wrote:
> Hi Heiner,
>
> On 3/5/2019 2:18 AM, Heiner Kallweit wrote:
>> On 04.03.2019 15:48, S-k, Shyam-sundar wrote:
>>> Hi Heiner,
>>>
>>> We noticed that, the recent changes for CL45 in net-next tree causing regression on AMD platforms. The following is the commit:
>>>
>>> 3ce2a02 net: phy: marvell10g: check for newly set aneg
>>>
>>> Now, I see that, this code is moved to phy-c45.c with newer commit
>>>
>>> 1af9f16 net: phy: add genphy_c45_check_and_restart_aneg
>>>
>>> With this change, the link never comes up. Can you please a re-look once before it enters mainline?
>>>
>>> Thanks,
>>>
>>> Shyam
>>>
>> Hi Shyam,
>>
>> thanks for the report. However the description quite vague, therefore I'd appreciate the following details:
>>
>> - The mentioned patch affects Marvell 10G PHY's only. Could you please provide:
>> - exact PHY model you're using
> Yes, we have on-board Marvell 88X3310 chip, which works as external PHY for AMD Ethernet controller.
>> - interface mode you're using
> RJ45.
>> - link speed you expect and advertised speeds from both sides
> Both advertised and link speeds are 1G SGMII
>>
>> - Some details regarding "AMD platform" would be helpful. What kind of board is it?
>>
>> - There's a known issue in genphy_c45_an_config_aneg(), however I'm not sure whether it could be related
>> to your issue. Could you please test the following patch whether it fixes the issue for you?
>> https://patchwork.ozlabs.org/patch/1051291/
>
> Thank you very much! This patch fixes the problem.
>
Great, thanks for the feedback. Patch has been applied to net-next few hours ago.
> -Shyam
>
>
Heiner
prev parent reply other threads:[~2019-03-05 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 14:48 net-next: new CL45 regression S-k, Shyam-sundar
2019-03-04 20:48 ` Heiner Kallweit
2019-03-05 3:07 ` S-k, Shyam-sundar
2019-03-05 6:58 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff23c988-f724-df6b-ea23-be74ff33de1c@gmail.com \
--to=hkallweit1@gmail.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).