From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serhey Popovych Subject: Re: [PATCH iproute2] gre/tunnel: Print erspan_index using print_uint() Date: Thu, 28 Dec 2017 17:48:32 +0200 Message-ID: References: <1514459579-20379-1-git-send-email-serhe.popovych@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="U0oNB6kV39fUzGUpmhH01lA4vMTolxjhA" Cc: Linux Kernel Network Developers To: William Tu Return-path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:44929 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750765AbdL1Psl (ORCPT ); Thu, 28 Dec 2017 10:48:41 -0500 Received: by mail-lf0-f68.google.com with SMTP id g63so23607647lfl.11 for ; Thu, 28 Dec 2017 07:48:41 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --U0oNB6kV39fUzGUpmhH01lA4vMTolxjhA Content-Type: multipart/mixed; boundary="vnHcbiJqU6jhufsLfrBxKZ3eP1Vln4d7p"; protected-headers="v1" From: Serhey Popovych To: William Tu Cc: Linux Kernel Network Developers Message-ID: Subject: Re: [PATCH iproute2] gre/tunnel: Print erspan_index using print_uint() References: <1514459579-20379-1-git-send-email-serhe.popovych@gmail.com> In-Reply-To: --vnHcbiJqU6jhufsLfrBxKZ3eP1Vln4d7p Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable > Hi Serhey, Hi William, Yes, iproute2-next/net-next branch contains fix already: we probably do not need proposed change. Sorry for noise. I'm currently focused on bug fixing in stable which affects my work for iproute2-next. All my future work will be based on iproute2-next as it contains refactoring, optimization and cleanups, not fixes. Sorry again and thanks for feedback. >=20 > On Thu, Dec 28, 2017 at 3:12 AM, Serhey Popovych > wrote: >> One is missing in JSON output because fprintf() >> is used instead of print_uint(). >> >> Signed-off-by: Serhey Popovych >> --- >> ip/link_gre.c | 3 ++- >> ip/link_gre6.c | 4 +++- >> 2 files changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/ip/link_gre.c b/ip/link_gre.c >> index 896bb19..1e331c8 100644 >> --- a/ip/link_gre.c >> +++ b/ip/link_gre.c >> @@ -476,7 +476,8 @@ static void gre_print_opt(struct link_util *lu, FI= LE *f, struct rtattr *tb[]) >> if (tb[IFLA_GRE_ERSPAN_INDEX]) { >> __u32 erspan_idx =3D rta_getattr_u32(tb[IFLA_GRE_ERSPA= N_INDEX]); >> >> - fprintf(f, "erspan_index %u ", erspan_idx); >> + print_uint(PRINT_ANY, >> + "erspan_index", "erspan_index %u ", erspan_= idx); >> } >> >=20 > Did you pull the latest code from net-next branch? > I think I already fix it. > William >=20 --vnHcbiJqU6jhufsLfrBxKZ3eP1Vln4d7p-- --U0oNB6kV39fUzGUpmhH01lA4vMTolxjhA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJaRRJVAAoJEBTawMmQ61bBUvcH/1uldSak9wOCmUyHrkT5vexT +D4DOGBUv8eq+t+VU/9qOdy3/GPi86d52oUaFQ/snu9Xvg+qufzu5to2WhHW+Qfr cUvtHpTeiYY1fmjA2BcSGsR0nuXOzze48efz7WtSvWglgsT2qcAx8t45yZ9ICgyp IvGAepA5rwe/L+oRviwAn9hysQfGCG2k8JGgzC2I4cMxvruHBB4ciPbj2U6OZscA CeSlUMT4Gro0xUA8l4+esBdscFq0Itd8E8GqpQlh+9fkH+Q35MnlXc9P+ZX0uZRg qfffpZGtAfOnv5fzG7bD/pWv8o4mEd+sIjUSpiAbR+DbHj5K8wqU21FlXT2tShk= =i5LY -----END PGP SIGNATURE----- --U0oNB6kV39fUzGUpmhH01lA4vMTolxjhA--