From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v4 3/7] dt-bindings: net: Document Intel pch_gbe binding Date: Mon, 5 Jun 2017 21:45:21 +0300 Message-ID: References: <20170602234042.22782-1-paul.burton@imgtec.com> <20170605173136.10795-1-paul.burton@imgtec.com> <20170605173136.10795-4-paul.burton@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Eric Dumazet , Jarod Wilson , Tobias Klauser , Mark Rutland , Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Burton , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: In-Reply-To: <20170605173136.10795-4-paul.burton-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hello! On 06/05/2017 08:31 PM, Paul Burton wrote: > Introduce documentation for a device tree binding for the Intel Platform > Controller Hub (PCH) GigaBit Ethernet (GBE) device. Although this is a > PCIe device & thus largely auto-detectable, this binding will be used to > provide the driver with the PHY reset GPIO. > > Signed-off-by: Paul Burton > Cc: David S. Miller > Cc: Eric Dumazet > Cc: Jarod Wilson > Cc: Mark Rutland > Cc: Rob Herring > Cc: Tobias Klauser > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org > Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > --- > > Changes in v4: None > > Changes in v3: > - New patch. > > Changes in v2: None > > Documentation/devicetree/bindings/net/pch_gbe.txt | 25 +++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/pch_gbe.txt > > diff --git a/Documentation/devicetree/bindings/net/pch_gbe.txt b/Documentation/devicetree/bindings/net/pch_gbe.txt > new file mode 100644 > index 000000000000..5de479c26b04 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/pch_gbe.txt > @@ -0,0 +1,25 @@ > +Intel Platform Controller Hub (PCH) GigaBit Ethernet (GBE) > + > +Required properties: > +- compatible: Should be the PCI vendor & device ID, eg. "pci8086,8802". > +- reg: Should be a PCI device number as specified by the PCI bus > + binding to IEEE Std 1275-1994. > +- phy-reset-gpios: Should be a GPIO list containing a single GPIO that > + resets the attached PHY when active. > + > +Example: > + > + eg20t_mac@2,0,1 { > + compatible = "pci8086,8802"; > + reg = <0x00020100 0 0 0 0>; > + phy-reset-gpios = <&eg20t_gpio 6 > + GPIO_ACTIVE_LOW>; > + }; > + > + eg20t_gpio: eg20t_gpio@2,0,2 { Name it "gpio@2,0,2" please -- the node names need to be generic and "gpio" is explicitly listed in the DT 1.0 spec... MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html