Netdev List
 help / color / mirror / Atom feed
From: Martin Habets <mhabets@solarflare.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	"David S . Miller" <davem@davemloft.net>,
	Bert Kenward <bkenward@solarflare.com>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
	Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
	Edward Cree <ecree@solarflare.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] net: ethernet: sfc: Make subdir logic consistent with other vendors
Date: Thu, 5 Jul 2018 11:54:00 +0100	[thread overview]
Message-ID: <ff513ddb-562f-6244-0560-7c7c80648b31@solarflare.com> (raw)
In-Reply-To: <20180704115013.28078-4-geert+renesas@glider.be>


On 04/07/18 12:50, Geert Uytterhoeven wrote:
> Both SFC and SFC_FALCON depend on NET_VENDOR_SOLARFLARE, hence use the
> latter to decide whether to descend into the sfc subdirectory.
> Move the rule to descend into sfc/falcon to the sfc subdirectory.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Martin Habets <mhabets@solarflare.com>

> ---
>  drivers/net/ethernet/Makefile     | 3 +--
>  drivers/net/ethernet/sfc/Makefile | 2 ++
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
> index 0c3ab7efff8c9ddb..22555e7fa752c67e 100644
> --- a/drivers/net/ethernet/Makefile
> +++ b/drivers/net/ethernet/Makefile
> @@ -80,8 +80,7 @@ obj-$(CONFIG_NET_VENDOR_SAMSUNG) += samsung/
>  obj-$(CONFIG_NET_VENDOR_SEEQ) += seeq/
>  obj-$(CONFIG_NET_VENDOR_SILAN) += silan/
>  obj-$(CONFIG_NET_VENDOR_SIS) += sis/
> -obj-$(CONFIG_SFC) += sfc/
> -obj-$(CONFIG_SFC_FALCON) += sfc/falcon/
> +obj-$(CONFIG_NET_VENDOR_SOLARFLARE) += sfc/
>  obj-$(CONFIG_NET_VENDOR_SGI) += sgi/
>  obj-$(CONFIG_NET_VENDOR_SMSC) += smsc/
>  obj-$(CONFIG_NET_VENDOR_SOCIONEXT) += socionext/
> diff --git a/drivers/net/ethernet/sfc/Makefile b/drivers/net/ethernet/sfc/Makefile
> index 3bac58d0f88b20f8..c5c297e78d068f41 100644
> --- a/drivers/net/ethernet/sfc/Makefile
> +++ b/drivers/net/ethernet/sfc/Makefile
> @@ -6,3 +6,5 @@ sfc-$(CONFIG_SFC_MTD)	+= mtd.o
>  sfc-$(CONFIG_SFC_SRIOV)	+= sriov.o siena_sriov.o ef10_sriov.o
>  
>  obj-$(CONFIG_SFC)	+= sfc.o
> +
> +obj-$(CONFIG_SFC_FALCON) += falcon/
> 

  reply	other threads:[~2018-07-05 10:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 11:50 [PATCH 0/3] net: ethernet: Miscellaneous Kconfig and Makefile cleanups Geert Uytterhoeven
2018-07-04 11:50 ` [PATCH 1/3] net: ethernet: Make NET_VENDOR_AURORA default to yes Geert Uytterhoeven
2018-07-04 11:50 ` [PATCH 2/3] net: ethernet: Add missing VENDOR to Cadence and Packet Engines symbols Geert Uytterhoeven
2018-07-04 11:50 ` [PATCH 3/3] net: ethernet: sfc: Make subdir logic consistent with other vendors Geert Uytterhoeven
2018-07-05 10:54   ` Martin Habets [this message]
2018-07-05 11:06 ` [PATCH 0/3] net: ethernet: Miscellaneous Kconfig and Makefile cleanups David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff513ddb-562f-6244-0560-7c7c80648b31@solarflare.com \
    --to=mhabets@solarflare.com \
    --cc=bkenward@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=ecree@solarflare.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net-drivers@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox