From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] r8169: Reinstate ALDPS and ASPM support Date: Tue, 5 Jun 2018 09:47:22 -0700 Message-ID: References: <20180605045812.17977-1-kai.heng.feng@canonical.com> <20180605141114.GC14873@lunn.ch> <20180605.101532.899235999013307302.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kai.heng.feng@canonical.com, hayeswang@realtek.com, hkallweit1@gmail.com, romieu@fr.zoreil.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ryankao@realtek.com, jiri@resnulli.us To: David Miller , andrew@lunn.ch Return-path: In-Reply-To: <20180605.101532.899235999013307302.davem@davemloft.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 06/05/2018 07:15 AM, David Miller wrote: > From: Andrew Lunn > Date: Tue, 5 Jun 2018 16:11:14 +0200 > >> No module parameter please. Just turn it on by default. Assuming >> testing shows works. > > Agreed. devlink would be a good candidate to add such configuration attributes, since you would be operating on the PCI function itself, thus allowing this to be on a per-device instance basis as opposed to global, which is what a module parameter is. -- Florian