From: Florian Fainelli <f.fainelli@gmail.com>
To: Max Filippov <jcmvbkbc@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Thierry Reding <thierry.reding@gmail.com>,
Tobias Klauser <tklauser@distanz.ch>,
stable@vger.kernel.org
Subject: Re: [PATCH] net: ethoc: enable NAPI before poll may be scheduled
Date: Tue, 6 Jun 2017 07:26:20 -0700 [thread overview]
Message-ID: <ff6b545e-abdb-fca6-27bf-957d6a59cd62@gmail.com> (raw)
In-Reply-To: <1496712676-11862-1-git-send-email-jcmvbkbc@gmail.com>
On 06/05/2017 06:31 PM, Max Filippov wrote:
> ethoc_reset enables device interrupts, ethoc_interrupt may schedule a
> NAPI poll before NAPI is enabled in the ethoc_open, which results in
> device being unable to send or receive anything until it's closed and
> reopened. In case the device is flooded with ingress packets it may be
> unable to recover at all.
> Move napi_enable above ethoc_reset in the ethoc_open to fix that.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Fixes: a1702857724f ("net: Add support for the OpenCores 10/100 Mbps
Ethernet MAC.")
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2017-06-06 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 1:31 [PATCH] net: ethoc: enable NAPI before poll may be scheduled Max Filippov
2017-06-06 6:05 ` Tobias Klauser
2017-06-06 14:26 ` Florian Fainelli [this message]
2017-06-06 20:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff6b545e-abdb-fca6-27bf-957d6a59cd62@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=jcmvbkbc@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).