From: Sathya Perla <sathya.perla@broadcom.com>
To: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>,
Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>
Cc: netdev@vger.kernel.org
Subject: RE: [PATCH net] be2net: perform temperature query in adapter regardless of its interface state
Date: Wed, 27 Jul 2016 09:35:46 +0530 [thread overview]
Message-ID: <ffb741d4f1204695951ee7fa4f4138df@mail.gmail.com> (raw)
In-Reply-To: <1469565582-5984-1-git-send-email-gpiccoli@linux.vnet.ibm.com>
> -----Original Message-----
> From: Guilherme G. Piccoli [mailto:gpiccoli@linux.vnet.ibm.com]
>
> The be2net driver performs fw temperature queries on be_worker()
routine, which is executed each second for
> each be_adapter. There is a frequency threshold to avoid fw query to
happens at each call to be_worker();
> instead, currently a fw query occurs once in 64 runs of the procedure.
>
> Nevertheless, this fw temperature query is invoked only for adapters
which interface is up, so we can see I/O
> errors on read of hwmon counters from userspace (from tools like
lm-sensors) in case we have adapters'
> functions which interface is down.
>
> This patch moves the fw query code to be invoked even if interface is
down.
> No functional changes were introduced.
>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Acked-by: Sathya Perla <sathya.perla@broadcom.com>
next prev parent reply other threads:[~2016-07-27 4:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 20:39 [PATCH net] be2net: perform temperature query in adapter regardless of its interface state Guilherme G. Piccoli
2016-07-27 4:05 ` Sathya Perla [this message]
2016-07-27 6:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffb741d4f1204695951ee7fa4f4138df@mail.gmail.com \
--to=sathya.perla@broadcom.com \
--cc=ajit.khaparde@broadcom.com \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox