From: Ivan Vecera <ivecera@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, sathya.perla@broadcom.com,
ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com,
somnath.kotur@broadcom.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "be2net: remove desc field from be_eq_obj"
Date: Tue, 23 Oct 2018 20:42:21 +0200 [thread overview]
Message-ID: <ffdc9846-e500-247a-8cd5-8f8a1a7102c3@redhat.com> (raw)
In-Reply-To: <20181023.110305.461689764889182451.davem@davemloft.net>
On 23.10.2018 20:03, David Miller wrote:
> From: Ivan Vecera <ivecera@redhat.com>
> Date: Tue, 23 Oct 2018 16:40:26 +0200
>
>> The mentioned commit needs to be reverted because we cannot pass
>> string allocated on stack to request_irq(). This function stores
>> uses this pointer for later use (e.g. /proc/interrupts) so we need
>> to keep this string persistently.
>>
>> Fixes: d6d9704af8f4 ("be2net: remove desc field from be_eq_obj")
>>
>> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>
> Please do not put empty lines between Fixes and the other tags,
> all tags should appear together as one contiguous group.
Sure Dave... sorry for that.
Ivan
prev parent reply other threads:[~2018-10-24 3:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 14:40 [PATCH] Revert "be2net: remove desc field from be_eq_obj" Ivan Vecera
2018-10-23 18:03 ` David Miller
2018-10-23 18:42 ` Ivan Vecera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffdc9846-e500-247a-8cd5-8f8a1a7102c3@redhat.com \
--to=ivecera@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).