From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Vecera Subject: Re: [PATCH] Revert "be2net: remove desc field from be_eq_obj" Date: Tue, 23 Oct 2018 20:42:21 +0200 Message-ID: References: <20181023144026.26180-1-ivecera@redhat.com> <20181023.110305.461689764889182451.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, sathya.perla@broadcom.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, linux-kernel@vger.kernel.org To: David Miller Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51420 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727758AbeJXDG5 (ORCPT ); Tue, 23 Oct 2018 23:06:57 -0400 In-Reply-To: <20181023.110305.461689764889182451.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 23.10.2018 20:03, David Miller wrote: > From: Ivan Vecera > Date: Tue, 23 Oct 2018 16:40:26 +0200 > >> The mentioned commit needs to be reverted because we cannot pass >> string allocated on stack to request_irq(). This function stores >> uses this pointer for later use (e.g. /proc/interrupts) so we need >> to keep this string persistently. >> >> Fixes: d6d9704af8f4 ("be2net: remove desc field from be_eq_obj") >> >> Signed-off-by: Ivan Vecera > > Please do not put empty lines between Fixes and the other tags, > all tags should appear together as one contiguous group. Sure Dave... sorry for that. Ivan