From: Roger Quadros <rogerq@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>,
Ravi Gunasekaran <r-gunasekaran@ti.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Stanislav Fomichev <sdf@google.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Rob Herring <robh@kernel.org>, Marek Majtyka <alardam@gmail.com>,
Yunsheng Lin <linyunsheng@huawei.com>,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 5/7] net: ethernet: ti: cpsw: Convert to platform remove callback returning void
Date: Sat, 18 Nov 2023 12:06:40 +0200 [thread overview]
Message-ID: <ffdd3f62-de0b-449b-ac2c-1ed9e9e3070e@kernel.org> (raw)
In-Reply-To: <20231117091655.872426-6-u.kleine-koenig@pengutronix.de>
On 17/11/2023 11:17, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
next prev parent reply other threads:[~2023-11-18 10:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 9:16 [PATCH 0/7] net: ethernet: Convert to platform remove callback Uwe Kleine-König
2023-11-17 9:16 ` [PATCH 1/7] net: ethernet: ti: am65-cpsw: Don't error out in .remove() Uwe Kleine-König
2023-11-17 9:51 ` Roger Quadros
2023-11-17 10:39 ` Uwe Kleine-König
2023-11-18 9:53 ` Roger Quadros
2023-11-17 9:16 ` [PATCH 2/7] net: ethernet: ti: cpsw: " Uwe Kleine-König
2023-11-18 10:00 ` Roger Quadros
2023-11-18 10:05 ` Roger Quadros
2023-11-19 9:40 ` Uwe Kleine-König
2023-11-17 9:16 ` [PATCH 3/7] net: ethernet: ti: cpsw-new: " Uwe Kleine-König
2023-11-18 7:21 ` Ilias Apalodimas
2023-11-17 9:17 ` [PATCH 4/7] net: ethernet: ti: am65-cpsw: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-18 10:06 ` Roger Quadros
2023-11-17 9:17 ` [PATCH 5/7] net: ethernet: ti: cpsw: " Uwe Kleine-König
2023-11-18 10:06 ` Roger Quadros [this message]
2023-11-17 9:17 ` [PATCH 6/7] net: ethernet: ti: cpsw-new: " Uwe Kleine-König
2023-11-18 10:06 ` Roger Quadros
2023-11-17 9:17 ` [PATCH 7/7] net: ethernet: ezchip: " Uwe Kleine-König
2023-11-17 9:27 ` [PATCH 0/7] net: ethernet: Convert to platform remove callback Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffdd3f62-de0b-449b-ac2c-1ed9e9e3070e@kernel.org \
--to=rogerq@kernel.org \
--cc=alardam@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=kernel@pengutronix.de \
--cc=linux-omap@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=r-gunasekaran@ti.com \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=sdf@google.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).