From: Tom Herbert <therbert@google.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] NIU support for skb->rxhash
Date: Fri, 23 Apr 2010 08:32:02 -0700 [thread overview]
Message-ID: <h2z65634d661004230832o4f7a6d35ub207bc301ee8925c@mail.gmail.com> (raw)
In-Reply-To: <20100423.011456.48472321.davem@davemloft.net>
> I looked into implementing this and it doesn't work. The
> problem is GRO want's to look into the packet very early
> and we want to batch GRO a set of packets into a big packet
> before shooting them over to a remote cpu.
>
Can you reconsider? :-) The majority of our servers see packet loads
which don't allow for much batching (a lot of small RPC messages), so
for those GRO is mostly unnecessary overhead and mechanisms that
improve unbatched packet performance are compelling. Also, if a
device already does LRO, I don't see that GRO could add a lot of value
anyway.
Tom
> This reminds me that we can start using ->rxhash as a quick
> mismatch check in the GRO flow matcher.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-04-23 15:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 11:21 [PATCH] NIU support for skb->rxhash David Miller
2010-04-22 11:43 ` Eric Dumazet
2010-04-22 21:19 ` David Miller
2010-04-23 8:14 ` David Miller
2010-04-23 15:32 ` Tom Herbert [this message]
2010-04-23 20:28 ` David Miller
2010-04-22 16:21 ` Stephen Hemminger
2010-04-22 21:36 ` David Miller
2010-04-22 22:11 ` Stephen Hemminger
2010-04-22 22:24 ` David Miller
2010-04-22 21:37 ` David Miller
2010-04-22 22:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=h2z65634d661004230832o4f7a6d35ub207bc301ee8925c@mail.gmail.com \
--to=therbert@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).